Skip to content

doc: clarify getAuthTag with authTagLength - #40713

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-clarify-getauthtag-authtaglength
Closed

doc: clarify getAuthTag with authTagLength#40713
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-clarify-getauthtag-authtaglength

Conversation

@tniessen

@tniessentniessen commented Nov 3, 2021

Copy link
Copy Markdown
Member

This behavior is only documented in createCipheriv and createCipher, but should also be mentioned in getAuthTag.

Refs: #40272
Refs: #20235

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Nov 3, 2021
@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2021
@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2021
@tniessen

tniessen commented Nov 8, 2021

Copy link
Copy Markdown
MemberAuthor

I'm not sure what's going on with the commit queue.

@targos

targos commented Nov 8, 2021

Copy link
Copy Markdown
Member

The commit queue is blocked on nodejs/admin#640

@targos

targos commented Nov 9, 2021

Copy link
Copy Markdown
Member

Landed in dd60161

targos pushed a commit that referenced this pull request Nov 9, 2021
@tniessen@targos
doc: clarify getAuthTag with authTagLength
dd60161
Refs: #40272
Refs: #20235
PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos closed this Nov 9, 2021
targos pushed a commit that referenced this pull request Nov 21, 2021
@tniessen@targos
doc: clarify getAuthTag with authTagLength
20d7d65
Refs: #40272
Refs: #20235
PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@tniessen@danielleadams
doc: clarify getAuthTag with authTagLength
23d188f
Refs: #40272
Refs: #20235
PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@tniessen@danielleadams
doc: clarify getAuthTag with authTagLength
7f9bf21
Refs: #40272
Refs: #20235
PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
@panvapanva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@targos@panva@Trott@lpinca@nodejs-github-bot