Skip to content

test: disable warnings to fix flaky test - #40739

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fix-flaky-json-warning-in-message
Closed

test: disable warnings to fix flaky test#40739
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fix-flaky-json-warning-in-message

Conversation

@aduh95

@aduh95aduh95 commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

Fixes: #40738

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2021
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
targos
targos approved these changes Nov 6, 2021
View reviewed changes

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you know why the test doesn't fail all the time on all platforms?

@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2021
@github-actions

github-actionsBot commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40741/

@aduh95

aduh95 commented Nov 6, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

LGTM, but do you know why the test doesn't fail all the time on all platforms?

Note sure, it could be related to something like a race condition between the warning being emitted asynchronously and the process crashing.

@github-actionsgithub-actionsBot mentioned this pull request Nov 7, 2021
Open
46 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40751/

@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2021
@github-actionsgithub-actionsBot mentioned this pull request Nov 8, 2021
Open
46 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40762/

@targostargos mentioned this pull request Nov 8, 2021
Closed
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40765/

@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40766/

@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40770/

@targos

targos commented Nov 8, 2021

Copy link
Copy Markdown
Member

Landed in a420da6

@targostargos closed this Nov 8, 2021
targos pushed a commit that referenced this pull request Nov 8, 2021
@aduh95@targos
test: disable warnings to fix flaky test
a420da6
Fixes: #40738
PR-URL: #40739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 8, 2021
@aduh95@targos
test: disable warnings to fix flaky test
e58cce4
Fixes: #40738
PR-URL: #40739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 8, 2021
Merged
@aduh95
aduh95 deleted the fix-flaky-json-warning-in-message branch November 8, 2021 18:00
This was referenced Nov 9, 2021
Open
Open
Open
This was referenced Nov 12, 2021
Open
Open
@danielleadams

danielleadams commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

@aduh95 I think this is related to #40250. Do you mind backporting this to v16.x-staging too?

@aduh95aduh95 mentioned this pull request Jan 30, 2022
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Jan 31, 2022
@aduh95
test: disable warnings to fix flaky test
0d728a3
Fixes: nodejs#40738
PR-URL: nodejs#40739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@aduh95@danielleadams
test: disable warnings to fix flaky test
b4fea14
Fixes: #40738
PR-URL: #40739
Backport-PR-URL: #41776
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test - esm_display_syntax_error_import_json_named_export

6 participants

@aduh95@nodejs-github-bot@targos@danielleadams@lpinca@Mesteery