Skip to content

stream: allow calling callback before promise - #40772

Closed
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:then-callback
Closed

stream: allow calling callback before promise#40772
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:then-callback

Conversation

@ronag

@ronagronag commented Nov 10, 2021

Copy link
Copy Markdown
Member

Refs: #39535

@ronag

ronag commented Nov 10, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/streams @mcollina wdyt?

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 10, 2021
mcollina
mcollina reviewed Nov 10, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test

@mcollina

mcollina commented Nov 10, 2021

Copy link
Copy Markdown
Member

Ok for me!

@ronag
ronag marked this pull request as ready for review November 10, 2021 08:41
@ronag
ronag requested a review from mcollinaNovember 10, 2021 08:41
@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. stream Issues and PRs related to the stream subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 10, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@paulrutter

paulrutter commented Nov 10, 2021

Copy link
Copy Markdown

Will this land in the next Node16 release? @ronag

@benjamingr

benjamingr commented Nov 10, 2021

Copy link
Copy Markdown
Member

I don't understand the impact well enough to review

mcollina
mcollina approved these changes Nov 10, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40817/

@VoltrexKeyvaVoltrexKeyva mentioned this pull request Nov 10, 2021
Merged
@github-actionsgithub-actionsBot mentioned this pull request Nov 11, 2021
Open
31 tasks
@paulrutter

paulrutter commented Nov 11, 2021

Copy link
Copy Markdown

This issue is important for knowing if we can proceed with Node16 on the short term.
Do you think this will land in next Node16 release @ronag ?

@mcollina

mcollina commented Nov 11, 2021

Copy link
Copy Markdown
Member

Do you think this will land in next Node16 release @ronag ?

This needs to be released in v17 first and after two weeks it could land on v16. I think the timeline is 4-8 weeks.

@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 12, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2021•
edited by ronag
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40845/ ✅

@github-actionsgithub-actionsBot mentioned this pull request Nov 13, 2021
Open
31 tasks
@ronag
ronag requested review from jasnell and lpincaNovember 13, 2021 13:48
@ronagronag added the review wanted PRs that need reviews. label Nov 13, 2021
mcollina
mcollina approved these changes Nov 13, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actionsgithub-actionsBot mentioned this pull request Nov 14, 2021
Open
41 tasks
ronag added a commit that referenced this pull request Nov 14, 2021
@ronag
stream: allow calling callback before promise
afe460e
Refs: #39535
PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ronag

ronag commented Nov 14, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in afe460e

@ronagronag closed this Nov 14, 2021
@ronagronag added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v16.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. review wanted PRs that need reviews. labels Nov 14, 2021
@GulajavaMinistudioGulajavaMinistudio mentioned this pull request Nov 14, 2021
Merged
This was referenced Nov 15, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
@ronag@targos
stream: allow calling callback before promise
7c4f9a3
Refs: #39535
PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
@targostargos mentioned this pull request Nov 26, 2021
Merged
@paulrutterpaulrutter mentioned this pull request Dec 28, 2021
Closed
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@ronag@danielleadams
stream: allow calling callback before promise
6275b07
Refs: #39535
PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@ronag@danielleadams
stream: allow calling callback before promise
1f722a1
Refs: #39535
PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ronag@mcollina@nodejs-github-bot@paulrutter@benjamingr@jasnell@lpinca@targos