Skip to content

async_hooks: eliminate require side effects - #40782

Merged
Trott merged 1 commit into
nodejs:masterfrom
Qard:eliminate-async_hooks-require-side-effects
Nov 13, 2021
Merged

async_hooks: eliminate require side effects#40782
Trott merged 1 commit into
nodejs:masterfrom
Qard:eliminate-async_hooks-require-side-effects

Conversation

@Qard

@QardQard commented Nov 10, 2021

Copy link
Copy Markdown
Member

Just a minor improvement to avoid any unintended side effects to requiring async_hooks.

cc @nodejs/async_hooks

@QardQard added the async_hooks Issues and PRs related to the async hooks subsystem. label Nov 10, 2021
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 10, 2021
RafaelGSS
RafaelGSS approved these changes Nov 10, 2021
View reviewed changes

@RafaelGSSRafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@targos

targos commented Nov 11, 2021

Copy link
Copy Markdown
Member

Is this related to https://twitter.com/evanhlucas/status/1458192210382528518 ?

@Qard

Qard commented Nov 11, 2021

Copy link
Copy Markdown
MemberAuthor

I had a quick look because of that. As far as I can tell this shouldn't trigger that though. I just saw a thing in looking back at the code that could be improved.

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40839/

@FlarnaFlarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 11, 2021
@github-actionsgithub-actionsBot mentioned this pull request Nov 12, 2021
Open
35 tasks
@Trott

Trott commented Nov 12, 2021

Copy link
Copy Markdown
Member

Does it make sense to add a test?

@Qard

Qard commented Nov 12, 2021

Copy link
Copy Markdown
MemberAuthor

Not sure how you'd even test it given that it's functionally identical other than just setting the trampoline function a little later and clearing it if the hooks are disabled. Do we have prior art on testing these environment fields? I guess it'd need to be a native test.

In any case, I'll be travelling for the next week so I can either deal with that after I get back or we can land as-is. I'm good either way as it's not really any substantial/important change.

@github-actionsgithub-actionsBot mentioned this pull request Nov 13, 2021
Open
31 tasks
Stephen Belanger@Trott
async_hooks: eliminate require side effects
689405c
PR-URL: nodejs#40782
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@Trott
Trottforce-pushed the eliminate-async_hooks-require-side-effects branch from 15a34d4 to 689405cCompareNovember 13, 2021 14:37
@Trott

Trott commented Nov 13, 2021

Copy link
Copy Markdown
Member

Landed in 689405c

@Trott
Trott merged commit 689405c into nodejs:masterNov 13, 2021
This was referenced Nov 14, 2021
Open
Open
Open
Open
@Qard
Qard deleted the eliminate-async_hooks-require-side-effects branch November 17, 2021 13:08
targos pushed a commit that referenced this pull request Nov 21, 2021
Stephen Belanger@targos
async_hooks: eliminate require side effects
4a971f6
PR-URL: #40782
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@targostargos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
Stephen Belanger@danielleadams
async_hooks: eliminate require side effects
4d22db2
PR-URL: #40782
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Stephen Belanger@danielleadams
async_hooks: eliminate require side effects
85a02ec
PR-URL: #40782
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JungMinuJungMinuJungMinu approved these changes
@FlarnaFlarnaFlarna approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@puzpuzpuzpuzpuzpuzpuzpuzpuz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Qard@targos@nodejs-github-bot@Trott@JungMinu@Flarna@RafaelGSS@puzpuzpuz