Skip to content

crypto: throw errors in SignTraits::DeriveBits - #40796

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:crypto-dont-swallow-errors-in-sign
Nov 15, 2021
Merged

crypto: throw errors in SignTraits::DeriveBits#40796
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:crypto-dont-swallow-errors-in-sign

Conversation

@tniessen

@tniessentniessen commented Nov 12, 2021

Copy link
Copy Markdown
Member

Throw OpenSSL errors instead of using a default error message. The default message is not helpful.

Fixes: #40794

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Nov 12, 2021
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Nov 13, 2021
Open
31 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40855/

@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2021
This was referenced Nov 14, 2021
Open
Open
@tniessen

tniessen commented Nov 15, 2021

Copy link
Copy Markdown
MemberAuthor

I am inclined to land this as a bug fix and not as a breaking change (cc @nodejs/crypto @jasnell).

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2021
@nodejs-github-bot
nodejs-github-bot merged commit d049a52 into nodejs:masterNov 15, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2021

Copy link
Copy Markdown
Collaborator

Landed in d049a52

This was referenced Nov 16, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
@tniessen@targos
crypto: throw errors in SignTraits::DeriveBits
2979c58
Fixes: #40794
PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@tniessen@danielleadams
crypto: throw errors in SignTraits::DeriveBits
90ce19d
Fixes: #40794
PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@tniessen@danielleadams
crypto: throw errors in SignTraits::DeriveBits
e60841b
Fixes: #40794
PR-URL: #40796
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@jasnelljasnelljasnell approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto.sign swallows OpenSSL errors

5 participants

@tniessen@nodejs-github-bot@panva@jasnell@richardlau