Uh oh!
There was an error while loading. Please reload this page.
[v16.x] Revert "doc: fix typo in stream docs" - #40819
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
This reverts commit 1db2ffd. Fixes: nodejs#40818
richardlau
approved these changes
Nov 15, 2021
richardlau
left a comment
Member
There was a problem hiding this comment.
A separate PR will also be required to update the metadata in master.
BethGriggs
approved these changes
Nov 16, 2021
jasnell
approved these changes
Nov 16, 2021
targos
approved these changes
Nov 16, 2021
targos
commented
Nov 16, 2021
Member
Do we know how it happened (so we can try to prevent it in the future)? |
lpinca
commented
Nov 16, 2021
MemberAuthor
targos
commented
Nov 16, 2021
Member
@lpinca Adding the labels beforehand is ideal, but my experience is that they are more often forgotten than added. It's still many times up to the releaser to decide whether to backport (fix the conflict) or not (add the label(s)). |
BethGriggs
commented
Nov 24, 2021
Member
Landed in 836fc27 (v16.x-staging) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1db2ffd.
Fixes: #40818