Skip to content

stream: fix the ReadableStreamBYOBReader error message - #40846

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:fix-byob-reader-error-message
Closed

stream: fix the ReadableStreamBYOBReader error message#40846
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:fix-byob-reader-error-message

Conversation

@jasnell

Copy link
Copy Markdown
Member

The error message was incorrect and unhelpful.

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 18, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@ronagronag added web streams and removed needs-ci PRs that need a full CI run. labels Nov 19, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in bc2944a

@jasnelljasnell closed this Nov 25, 2021
targos pushed a commit that referenced this pull request Nov 26, 2021
PR-URL: #40846
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@targostargos mentioned this pull request Nov 26, 2021
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
PR-URL: #40846
Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #40846
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jasnell@nodejs-github-bot@ronag