Skip to content

build: fix tools.yml errors - #40870

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:tools.yml
Nov 19, 2021
Merged

build: fix tools.yml errors#40870
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:tools.yml

Conversation

@Trott

@TrottTrott commented Nov 19, 2021

Copy link
Copy Markdown
Member

No description provided.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 19, 2021
@Trott

Trott commented Nov 19, 2021

Copy link
Copy Markdown
MemberAuthor

Refs: https://github.com/nodejs/node/runs/4195785114?check_suite_focus=true

@github-actions

github-actionsBot commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 19, 2021
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2021
@nodejs-github-bot
nodejs-github-bot merged commit e0233fc into nodejs:masterNov 19, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2021

Copy link
Copy Markdown
Collaborator

Landed in e0233fc

@Trott
Trott deleted the tools.yml branch November 19, 2021 13:44
targos pushed a commit that referenced this pull request Nov 21, 2021
@Trott@targos
build: fix tools.yml errors
e793331
PR-URL: #40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@Trott@danielleadams
build: fix tools.yml errors
c199fa7
PR-URL: #40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
build: fix tools.yml errors
323c058
PR-URL: #40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@aduh95aduh95aduh95 approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@nodejs-github-bot@lpinca@targos@aduh95@VoltrexKeyva