Skip to content

test: improve test coverage of readline/promises - #40876

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
kuriyosh:test-readline-promise
Nov 23, 2021
Merged

test: improve test coverage of readline/promises#40876
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
kuriyosh:test-readline-promise

Conversation

@kuriyosh

@kuriyoshkuriyosh commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

This improves a test coverage in lib/readline/promises.
It tests throwing ABORT_ERROR when the question method is executed with an aborted signal.

ref: https://coverage.nodejs.org/coverage-0c2011c6c5d311a9/lib/readline/promises.js.html#L33

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 19, 2021
@kuriyosh
kuriyoshforce-pushed the test-readline-promise branch from 69f4058 to 97b3f58CompareNovember 19, 2021 08:15
Ayase-252
Ayase-252 reviewed Nov 19, 2021
View reviewed changes

@Ayase-252Ayase-252 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few comments.

Comment threadtest/parallel/test-readline-promises-interface.js
Ayase-252
Ayase-252 reviewed Nov 19, 2021
View reviewed changes
Comment threadtest/parallel/test-readline-promises-interface.js Outdated
@kuriyosh

kuriyosh commented Nov 19, 2021

Copy link
Copy Markdown
ContributorAuthor

@Ayase-252
Thank you your comments! I totally agreed and fixed it.

@Ayase-252Ayase-252 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40989/

@github-actionsgithub-actionsBot mentioned this pull request Nov 20, 2021
Open
47 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41007/

This was referenced Nov 21, 2021
Open
Open
@Ayase-252Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 22, 2021
@github-actionsgithub-actionsBot mentioned this pull request Nov 23, 2021
Open
45 tasks
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 23, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2021
@nodejs-github-bot
nodejs-github-bot merged commit bb3ff81 into nodejs:masterNov 23, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2021

Copy link
Copy Markdown
Collaborator

Landed in bb3ff81

@github-actionsgithub-actionsBot mentioned this pull request Nov 24, 2021
Open
45 tasks
targos pushed a commit that referenced this pull request Nov 26, 2021
@kuriyosh@targos
test: improve test coverage of readline/promises
ae12a60
PR-URL: #40876
Refs: https://coverage.nodejs.org/coverage-0c2011c6c5d311a9/lib/readline/promises.js.html#L33
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 26, 2021
Merged
@danielleadams

danielleadams commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

@kuriyosh do you mind backporting this to 16.x? When I went to pull it into the next release, there was a breaking test.

@kuriyosh

kuriyosh commented Feb 4, 2022

Copy link
Copy Markdown
ContributorAuthor

@kuriyosh
Of course. Please ping me if I have any necessary actions.

This was referenced Jan 10, 2026
Closed
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@Ayase-252Ayase-252Ayase-252 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kuriyosh@nodejs-github-bot@danielleadams@jasnell@lpinca@Ayase-252@targos@aduh95