Skip to content

doc: update BUILDING.md section on running tests - #40933

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:running-tests
Nov 25, 2021
Merged

doc: update BUILDING.md section on running tests#40933
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:running-tests

Conversation

@Trott

@TrottTrott commented Nov 23, 2021

Copy link
Copy Markdown
Member

Refs: #40920

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 23, 2021
@TrottTrott mentioned this pull request Nov 23, 2021
Closed
@VoltrexKeyva

VoltrexKeyva commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

LGTM except for the typo in the commit message title. :)

@TrottTrott changed the title doc: udpate BUILDING.md section on running testsdoc: update BUILDING.md section on running testsNov 23, 2021
@Trott

Trott commented Nov 23, 2021

Copy link
Copy Markdown
MemberAuthor

LGTM except for the typo in the commit message title. :)

Whoops! Fixed.

aduh95
aduh95 reviewed Nov 23, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this was introduced prior to this PR, but shouldn't we be using bash instead of text? And shouldn't we avoid to name the python executable (which is named python3 in many systems I believe)?

Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated
@Trott
Trottforce-pushed the running-tests branch 6 times, most recently from 384f16f to 82851fdCompareNovember 23, 2021 15:15
@Trott

Trott commented Nov 23, 2021

Copy link
Copy Markdown
MemberAuthor

@aduh95 I believe I've addressed all your suggestions. If I've missed something, please let me know!

Trott
Trott commented Nov 23, 2021
View reviewed changes
Comment threadBUILDING.md Outdated
@Trott
Trottforce-pushed the running-tests branch 2 times, most recently from 442d353 to 82e292bCompareNovember 23, 2021 15:30
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2021
@nodejs-github-bot
nodejs-github-bot merged commit a5d3449 into nodejs:masterNov 25, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2021

Copy link
Copy Markdown
Collaborator

Landed in a5d3449

@Trott
Trott deleted the running-tests branch November 26, 2021 07:25
targos pushed a commit that referenced this pull request Nov 26, 2021
@Trott@targos
doc: update BUILDING.md section on running tests
130777a
Refs: #40920
PR-URL: #40933
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@Trott@danielleadams
doc: update BUILDING.md section on running tests
308fe7d
Refs: #40920
PR-URL: #40933
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
doc: update BUILDING.md section on running tests
02e9c2e
Refs: #40920
PR-URL: #40933
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments
@tniessentniessentniessen approved these changes
@aduh95aduh95aduh95 approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@VoltrexKeyva@nodejs-github-bot@tniessen@richardlau@aduh95