Skip to content

build: use gh cli in workflows file - #40985

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
Mesteery:gh-cli-actions
Dec 14, 2021
Merged

build: use gh cli in workflows file#40985
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
Mesteery:gh-cli-actions

Conversation

@Mesteery

@MesteeryMesteery commented Nov 26, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@MesteeryMesteery added the blocked PRs that are blocked by other issues or PRs. label Nov 26, 2021
@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 26, 2021
@Mesteery

Mesteery commented Nov 26, 2021

Copy link
Copy Markdown
ContributorAuthor

Waiting the next release of GitHub CLI for cli/cli@1eb790c.

@MesteeryMesteery mentioned this pull request Nov 26, 2021
Closed
aduh95
aduh95 reviewed Nov 27, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to filter the label it seems.

Comment thread.github/workflows/auto-start-ci.yml Outdated
Comment thread.github/workflows/commit-queue.yml Outdated
@Mesteery

Mesteery commented Nov 27, 2021

Copy link
Copy Markdown
ContributorAuthor

You forgot to filter the label it seems.

Ah indeed, thank you!

aduh95
aduh95 reviewed Nov 27, 2021
View reviewed changes
Comment thread.github/workflows/commit-queue.yml Outdated
@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2021
@aduh95

aduh95 commented Nov 27, 2021

Copy link
Copy Markdown
Contributor

Is it both blocked and author ready? That seems contradictory.

@MesteeryMesteery removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2021
@Mesteery

Mesteery commented Nov 27, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Is it both blocked and author ready? That seems contradictory.

For me it does not seem contradictory, there is also #38889 for example.

Description of author ready:

PRs that have at least one approval, no pending requests for changes, and a CI started.

@MesteeryMesteery added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Dec 14, 2021
@Mesteery

Mesteery commented Dec 14, 2021

Copy link
Copy Markdown
ContributorAuthor

GitHub CLI 2.3.0 is now available in GitHub Actions runners.

aduh95
aduh95 reviewed Dec 14, 2021
View reviewed changes
Comment thread.github/workflows/comment-labeled.yml Outdated
@Mesteery@aduh95
Update .github/workflows/comment-labeled.yml
792b88f
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 14, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 14, 2021
@nodejs-github-bot
nodejs-github-bot merged commit f404cd5 into nodejs:masterDec 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2021

Copy link
Copy Markdown
Collaborator

Landed in f404cd5

@Mesteery
Mesteery deleted the gh-cli-actions branch December 14, 2021 19:07
@Trott

Trott commented Dec 14, 2021

Copy link
Copy Markdown
Member

Is it at all possible that this broke the label-commenting workflow? Or maybe it was already broken? (Or maybe I don't understand how it's supposed to work?) After this landed, I labeled #14086 with stalled but no comment has been posted there yet from the workflow.

@Trott

Trott commented Dec 14, 2021

Copy link
Copy Markdown
Member

https://github.com/nodejs/node/runs/4525021875?check_suite_focus=true

Run gh pr comment "$NUMBER" --repo nodejs/node --body "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open."
gh pr comment "$NUMBER" --repo nodejs/node --body "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open."
shell: /usr/bin/bash -e {0}
env:
NUMBER: 14086
GITHUB_TOKEN: ***
GraphQL: Could not resolve to a PullRequest with the number of 14086. (repository.pullRequest)
Error: Process completed with exit code 1.

Mesteery added a commit to Mesteery/node that referenced this pull request Dec 14, 2021
@Mesteery
build: fix comment-labeled workflow
f52a6b8
Refs: nodejs#40985 (comment)
@MesteeryMesteery mentioned this pull request Dec 14, 2021
Merged
@Mesteery

Mesteery commented Dec 14, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ah, sorry, commenting on PRs and issues only works with gh issue comment.

Improve issue comment re: overfetching, handling PRs

cli/cli@1eb790c

nodejs-github-bot pushed a commit that referenced this pull request Dec 14, 2021
@Mesteery
build: fix comment-labeled workflow
6267e55
Refs: #40985 (comment)
PR-URL: #41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Dec 15, 2021

Copy link
Copy Markdown
Member

I'm not sure if this wasn't the case before this PR, but it looks like Commit Queue is failing when there are no PRs for it to land. I would expect it to succeed in that case. Example: https://github.com/nodejs/node/runs/4540327006?check_suite_focus=true

Because the last command is a gh command, I'm guessing this PR might have had something to do with it, but I could be wrong.

@TrottTrott mentioned this pull request Dec 15, 2021
Merged
@aduh95aduh95 mentioned this pull request Dec 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Dec 16, 2021
@Mesteery@danielleadams
build: use gh cli in workflows file
a18e886
PR-URL: #40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 16, 2021
@Mesteery@danielleadams
build: fix comment-labeled workflow
de9ec31
Refs: #40985 (comment)
PR-URL: #41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 16, 2021
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Dec 17, 2021
@aduh95
tools: fix GitHub Actions status when CQ is empty
2fb7aaf
Refs: nodejs#40985 (comment)
danielleadams pushed a commit that referenced this pull request Dec 17, 2021
@Mesteery@danielleadams
build: use gh cli in workflows file
61c53a6
PR-URL: #40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 17, 2021
@Mesteery@danielleadams
build: fix comment-labeled workflow
85f1537
Refs: #40985 (comment)
PR-URL: #41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 18, 2021
@aduh95
tools: fix GitHub Actions status when CQ is empty
587b167
Refs: #40985 (comment)
PR-URL: #41193
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 14, 2022
@aduh95@targos
tools: fix GitHub Actions status when CQ is empty
c44185c
Refs: #40985 (comment)
PR-URL: #41193
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Mesteery@danielleadams
build: use gh cli in workflows file
e23d862
PR-URL: #40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Mesteery@danielleadams
build: fix comment-labeled workflow
352ee3b
Refs: #40985 (comment)
PR-URL: #41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Mesteery@danielleadams
build: use gh cli in workflows file
19f8b48
PR-URL: #40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Mesteery@danielleadams
build: fix comment-labeled workflow
bc6edfd
Refs: #40985 (comment)
PR-URL: #41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@aduh95@danielleadams
tools: fix GitHub Actions status when CQ is empty
4bc5efe
Refs: #40985 (comment)
PR-URL: #41193
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Mesteery@danielleadams
build: use gh cli in workflows file
7756e1c
PR-URL: #40985
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Mesteery@danielleadams
build: fix comment-labeled workflow
0b411c4
Refs: #40985 (comment)
PR-URL: #41176
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@aduh95@danielleadams
tools: fix GitHub Actions status when CQ is empty
95568dc
Refs: #40985 (comment)
PR-URL: #41193
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
+1 more reviewer
@ssua91ssua91ssua91 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mesteery@aduh95@nodejs-github-bot@Trott@ssua91