Skip to content

test: deflake test-trace-atomics-wait - #41018

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:deflake/trace-atomics-wait
Dec 3, 2021
Merged

test: deflake test-trace-atomics-wait#41018
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
lpinca:deflake/trace-atomics-wait

Conversation

@lpinca

Copy link
Copy Markdown
Member

Add possible outcome to the expectedTimelines array.

Fixes: #41010

Add possible outcome to the `expectedTimelines` array.
Fixes: nodejs#41010
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 29, 2021
@lpinca

Copy link
Copy Markdown
MemberAuthor

Before:

$ ./tools/test.py --repeat=1000 test/parallel/test-trace-atomics-wait.js === release test-trace-atomics-wait === Path: parallel/test-trace-atomics-wait
+++ normalized stdout +++
[Thread 0] Atomics.wait(<address> + 0, 1, inf) started
[Thread 0] Atomics.wait(<address> + 0, 1, inf) did not wait because the values mismatched
[Thread 0] Atomics.wait(<address> + 0, 0, 10) started
[Thread 0] Atomics.wait(<address> + 0, 0, 10) timed out
[Thread 1] Atomics.wait(<address> + 4, -1, inf) started
[Thread 0] Atomics.wait(<address> + 4, 0, inf) started
[Thread 0] Atomics.wait(<address> + 4, 0, inf) did not wait because the values mismatched
[Thread 1] Atomics.wait(<address> + 4, -1, inf) was woken up by another thread
--- normalized stdout ---
node:assert:400
throw err;
^
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert(expectedTimelines.includes(actualTimeline))
at Object.<anonymous> (/Users/luigi/code/node/test/parallel/test-trace-atomics-wait.js:101:1)
at Module._compile (node:internal/modules/cjs/loader:1097:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
at Module.load (node:internal/modules/cjs/loader:975:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:17:47 {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '=='
}
Node.js v18.0.0-pre
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-trace-atomics-wait.js
...
=== release test-trace-atomics-wait === Path: parallel/test-trace-atomics-wait
+++ normalized stdout +++
[Thread 0] Atomics.wait(<address> + 0, 1, inf) started
[Thread 0] Atomics.wait(<address> + 0, 1, inf) did not wait because the values mismatched
[Thread 0] Atomics.wait(<address> + 0, 0, 10) started
[Thread 0] Atomics.wait(<address> + 0, 0, 10) timed out
[Thread 1] Atomics.wait(<address> + 4, -1, inf) started
[Thread 0] Atomics.wait(<address> + 4, 0, inf) started
[Thread 0] Atomics.wait(<address> + 4, 0, inf) did not wait because the values mismatched
[Thread 1] Atomics.wait(<address> + 4, -1, inf) was woken up by another thread
--- normalized stdout ---
node:assert:400
throw err;
^
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert(expectedTimelines.includes(actualTimeline))
at Object.<anonymous> (/Users/luigi/code/node/test/parallel/test-trace-atomics-wait.js:101:1)
at Module._compile (node:internal/modules/cjs/loader:1097:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
at Module.load (node:internal/modules/cjs/loader:975:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:17:47 {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '=='
}
Node.js v18.0.0-pre
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-trace-atomics-wait.js
[00:21|% 100|+ 995|- 5]: Done 

After:

$ ./tools/test.py --repeat=1000 test/parallel/test-trace-atomics-wait.js [00:21|% 100|+ 1000|- 0]: Done

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2021
@nodejs-github-bot
nodejs-github-bot merged commit fd66ae8 into nodejs:masterDec 3, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in fd66ae8

danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Add possible outcome to the `expectedTimelines` array.
Fixes: #41010
PR-URL: #41018
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca
lpinca deleted the deflake/trace-atomics-wait branch January 20, 2022 18:48
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Add possible outcome to the `expectedTimelines` array.
Fixes: #41010
PR-URL: #41018
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Add possible outcome to the `expectedTimelines` array.
Fixes: #41010
PR-URL: #41018
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Add possible outcome to the `expectedTimelines` array.
Fixes: #41010
PR-URL: #41018
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate flaky test - test-trace-atomics-wait

5 participants

@lpinca@nodejs-github-bot@jasnell@BridgeAR@VoltrexKeyva