Skip to content

fix withoutintl builds - #41078

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
richardlau:rollback
Dec 4, 2021
Merged

fix withoutintl builds#41078
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
richardlau:rollback

Conversation

@richardlau

@richardlaurichardlau commented Dec 3, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

Refs: #41077
Refs: #41036

Consider this a quick fix to unblock the CI as the automated tooling will attempt to update again the next time it is run. It's getting late here on a Friday evening so maybe someone else can take a look and figure out if the break is due to highlight.js or something latent in Node.js/V8.

@richardlau
tools: rollback highlight.js
5d66f03
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Dec 3, 2021
@richardlaurichardlau added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 3, 2021
@github-actions

github-actionsBot commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41310/

aduh95
aduh95 reviewed Dec 3, 2021
View reviewed changes
Comment threadtools/doc/package.json
},
"devDependencies": {
"highlight.js": "^11.3.1",
"highlight.js": "^11.2.0",

@aduh95aduh95Dec 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You meant to pin the version, right?

Suggested change
"highlight.js": "^11.2.0",
"highlight.js": "11.2.0",

@richardlaurichardlauDec 3, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just partially undid the package updates in #41036. I think the package-lock.json takes care of it as the Makefile runs npm ci:

node/Makefile

Lines 686 to 691 in a257294

tools/doc/node_modules: tools/doc/package.json
@if [ "$(shell $(node_use_openssl))"!="true" ];then\
echo"Skipping tools/doc/node_modules (no crypto)";\
else\
cd tools/doc &&$(call available-node,$(run-npm-ci))\
fi

@richardlaurichardlauDec 3, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't start failing until #41036 was merged -- the newer highlight.js was published two months ago: https://www.npmjs.com/package/highlight.js

@richardlaurichardlauDec 3, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW https://ci.nodejs.org/job/node-test-commit-linux-containered/29828/nodes=ubuntu1804_sharedlibs_withoutintl_x64/ passed.

@TrottTrott mentioned this pull request Dec 4, 2021
Closed
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2021
@nodejs-github-bot
nodejs-github-bot merged commit c802c4b into nodejs:masterDec 4, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2021

Copy link
Copy Markdown
Collaborator

Landed in c802c4b

@richardlau
richardlau deleted the rollback branch December 4, 2021 14:53
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@richardlau@danielleadams
tools: rollback highlight.js
9cfdf15
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@richardlau@danielleadams
tools: rollback highlight.js
51253a3
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@richardlau@danielleadams
tools: rollback highlight.js
e0cc79d
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@richardlau@danielleadams
tools: rollback highlight.js
f9cf50f
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardlau@nodejs-github-bot@Trott@aduh95