Skip to content

tools: strip comments from lint-md rollup output - #41092

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:strip-comments
Dec 7, 2021
Merged

tools: strip comments from lint-md rollup output#41092
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:strip-comments

Conversation

@Trott

@TrottTrott commented Dec 5, 2021

Copy link
Copy Markdown
Member

@Trott
Trott requested a review from targosDecember 5, 2021 16:29
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 5, 2021
bnb
bnb approved these changes Dec 6, 2021
@TrottTrott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 7, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we certain we keep all necessary copyright / license blocks intact?

@Trott

Trott commented Dec 7, 2021

Copy link
Copy Markdown
MemberAuthor

Are we certain we keep all necessary copyright / license blocks intact?

Unfortunately, that's a good question. And, in fact, I'm not sure we aren't in license violation already by using rollup but not distributing LICENSE files that come with the code. If that's a problem, then we may need to consider either checking in the entire node_modules directory (like we do for ESLint) or else going back to not shipping the markdown linter with the repo at all and requiring installation to use.

@Trott

Trott commented Dec 7, 2021

Copy link
Copy Markdown
MemberAuthor

Are we certain we keep all necessary copyright / license blocks intact?

Unfortunately, that's a good question. And, in fact, I'm not sure we aren't in license violation already by using rollup but not distributing LICENSE files that come with the code. If that's a problem, then we may need to consider either checking in the entire node_modules directory (like we do for ESLint) or else going back to not shipping the markdown linter with the repo at all and requiring installation to use.

I did a grep for "Permission" and "Copyright" and came up empty. It also leaves @license JSDoc entries intact. So it seems that we're good. It does not appear to be removing license text or copyright text.

@Trott

Trott commented Dec 7, 2021

Copy link
Copy Markdown
MemberAuthor

So it seems that we're good. It does not appear to be removing license text or copyright text.

Although that doesn't answer the question as to whether we should be including LICENSE files etc. But if so, that's already a problem. This PR does not exacerbate it, at least.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2021
@nodejs-github-bot
nodejs-github-bot merged commit c93a639 into nodejs:masterDec 7, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in c93a639

@Trott
Trott deleted the strip-comments branch December 7, 2021 23:51
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Refs: #41081 (comment)
PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Refs: #41081 (comment)
PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Refs: #41081 (comment)
PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Refs: #41081 (comment)
PR-URL: #41092
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@bnb@lpinca@targos@tniessen@BridgeAR