Skip to content

doc: remove OpenJSF Slack nodejs from support doc - #41108

Merged
Trott merged 1 commit into
masterfrom
Trott-patch-1
Dec 9, 2021
Merged

doc: remove OpenJSF Slack nodejs from support doc#41108
Trott merged 1 commit into
masterfrom
Trott-patch-1

Conversation

@Trott

@TrottTrott commented Dec 7, 2021

Copy link
Copy Markdown
Member

The OpenJSF Slack nodejs channel has a description that reads:

🚨 For Node.js application development questions, see:

Let's not send people with support questions there just to get
ignored or redirected elsewhere.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 7, 2021
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2021
mhdawson
mhdawson approved these changes Dec 7, 2021
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrottTrott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 9, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2021

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/41108
✔ Done loading data for nodejs/node/pull/41108
----------------------------------- PR info ------------------------------------
Title doc: remove OpenJSF Slack nodejs from support doc (#41108)
Author Rich Trott (@Trott)
Branch Trott:Trott-patch-1 -> nodejs:master
Labels meta, author ready
Commits 1
- doc: remove OpenJSF Slack nodejs from support doc
Committers 1
- GitHub PR-URL: https://github.com/nodejs/node/pull/41108
Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Beth Griggs Reviewed-By: Michael Dawson Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41108
Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Beth Griggs Reviewed-By: Michael Dawson Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh --------------------------------------------------------------------------------
ℹ This PR was created on Tue, 07 Dec 2021 14:15:11 GMT
✔ Approvals: 7
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41108#pullrequestreview-825371040
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41108#pullrequestreview-825473521
✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/41108#pullrequestreview-825491926
✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/41108#pullrequestreview-825660525
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41108#pullrequestreview-825698868
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41108#pullrequestreview-825761735
✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41108#pullrequestreview-827545704
✖ GitHub CI is still running
ℹ Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1559577870

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 9, 2021
@Trott
doc: remove OpenJSF Slack nodejs from support doc
3697587
The OpenJSF Slack nodejs channel has a description that reads:
> 🚨 For Node.js application development questions, see:
>
> - Node Slackers: https://www.nodeslackers.com/
> - Node.js help repo: https://github.com/nodejs/help
Let's not send people with support questions there just to get
ignored or redirected elsewhere.
PR-URL: #41108
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@Trott

Trott commented Dec 9, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 3697587

@Trott
Trott merged commit 3697587 into masterDec 9, 2021
@Trott
Trott deleted the Trott-patch-1 branch December 9, 2021 16:15
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott@danielleadams
doc: remove OpenJSF Slack nodejs from support doc
9569180
The OpenJSF Slack nodejs channel has a description that reads:
> 🚨 For Node.js application development questions, see:
>
> - Node Slackers: https://www.nodeslackers.com/
> - Node.js help repo: https://github.com/nodejs/help
Let's not send people with support questions there just to get
ignored or redirected elsewhere.
PR-URL: #41108
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott@danielleadams
doc: remove OpenJSF Slack nodejs from support doc
f8f2382
The OpenJSF Slack nodejs channel has a description that reads:
> 🚨 For Node.js application development questions, see:
>
> - Node Slackers: https://www.nodeslackers.com/
> - Node.js help repo: https://github.com/nodejs/help
Let's not send people with support questions there just to get
ignored or redirected elsewhere.
PR-URL: #41108
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott@danielleadams
doc: remove OpenJSF Slack nodejs from support doc
499b7bc
The OpenJSF Slack nodejs channel has a description that reads:
> 🚨 For Node.js application development questions, see:
>
> - Node Slackers: https://www.nodeslackers.com/
> - Node.js help repo: https://github.com/nodejs/help
Let's not send people with support questions there just to get
ignored or redirected elsewhere.
PR-URL: #41108
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
doc: remove OpenJSF Slack nodejs from support doc
179886f
The OpenJSF Slack nodejs channel has a description that reads:
> 🚨 For Node.js application development questions, see:
>
> - Node Slackers: https://www.nodeslackers.com/
> - Node.js help repo: https://github.com/nodejs/help
Let's not send people with support questions there just to get
ignored or redirected elsewhere.
PR-URL: #41108
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
@aduh95aduh95aduh95 approved these changes
+2 more reviewers
@mhdawsonmhdawsonmhdawson approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott@nodejs-github-bot@lpinca@cjihrig@tniessen@BethGriggs@mhdawson@aduh95@VoltrexKeyva