Skip to content

tools: update ESLint to 8.4.1 - #41114

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:eslint-841
Dec 10, 2021
Merged

tools: update ESLint to 8.4.1#41114
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:eslint-841

Conversation

@Trott

@TrottTrott commented Dec 7, 2021

Copy link
Copy Markdown
Member

No description provided.

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2021
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 7, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41414/

tniessen
tniessen approved these changes Dec 8, 2021
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 9, 2021
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2021
@nodejs-github-bot
nodejs-github-bot merged commit 03c9837 into nodejs:masterDec 10, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2021

Copy link
Copy Markdown
Collaborator

Landed in 03c9837

@Trott
Trott deleted the eslint-841 branch December 10, 2021 12:58
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott@danielleadams
tools: update ESLint to 8.4.1
70e6fe8
PR-URL: #41114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
tools: update ESLint to 8.4.1
3dc8483
PR-URL: #41114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@lpinca@tniessen@VoltrexKeyva@danielleadams@aduh95