Skip to content

stream: add isErrored helper - #41121

Closed
ronag wants to merge 6 commits into
nodejs:masterfrom
nxtedition:stream-is-errored
Closed

stream: add isErrored helper#41121
ronag wants to merge 6 commits into
nodejs:masterfrom
nxtedition:stream-is-errored

Conversation

@ronag

@ronagronag commented Dec 9, 2021

Copy link
Copy Markdown
Member

@ronagronag added stream Issues and PRs related to the stream subsystem. web streams labels Dec 9, 2021
@ronag
ronag requested review from jasnell and mcollinaDecember 9, 2021 08:16
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 9, 2021
@ronag

ronag commented Dec 9, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/streams

@ronagronag mentioned this pull request Dec 9, 2021
Merged
mcollina
mcollina approved these changes Dec 9, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag
ronagforce-pushed the stream-is-errored branch 2 times, most recently from c76beb4 to 1e2413bCompareDecember 9, 2021 09:33
@ronagronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Dec 9, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41432/

lpinca
lpinca reviewed Dec 9, 2021
View reviewed changes
Comment threaddoc/api/stream.md Outdated
mscdex
mscdex reviewed Dec 9, 2021
View reviewed changes
Comment threaddoc/api/stream.md Outdated
mscdex
mscdex reviewed Dec 9, 2021
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@mscdex

mscdex commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

Is there a reason this is only for Readable streams?

Also, maybe we should name it hasErrored() or hasError() instead?

ronag
ronag commented Dec 9, 2021
View reviewed changes
Comment threaddoc/api/stream.md Outdated
ronagand others added 2 commits December 9, 2021 15:34
@ronag@lpinca@mscdex
Apply suggestions from code review
47b2605
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
@ronag@mscdex
Update doc/api/stream.md
571739e
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
ronag
ronag commented Dec 9, 2021
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@ronag
ronag requested review from lpinca and mscdexDecember 9, 2021 14:34
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41484/

This was referenced Dec 15, 2021
Open
Open
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41512/

@ronagronag mentioned this pull request Dec 16, 2021
Closed
@nodejs-github-bot

nodejs-github-bot commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41513/

@ronag

ronag commented Dec 16, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 752d75d

ronag added a commit that referenced this pull request Dec 16, 2021
@ronag
stream: add isErrored helper
752d75d
Refs: nodejs/undici#1134
PR-URL: #41121
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@ronagronag closed this Dec 16, 2021
@ronagronag mentioned this pull request Dec 16, 2021
Merged
@lpinca

lpinca commented Dec 16, 2021

Copy link
Copy Markdown
Member

It's a bit too late but I agree with @mscdex about the name. hasErrored() seems more correct.

danielleadams pushed a commit that referenced this pull request Dec 16, 2021
@ronag@danielleadams
stream: add isErrored helper
9b0cafd
Refs: nodejs/undici#1134
PR-URL: #41121
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Dec 17, 2021
Open
22 tasks
danielleadams pushed a commit that referenced this pull request Dec 17, 2021
@ronag@danielleadams
stream: add isErrored helper
b59c513
Refs: nodejs/undici#1134
PR-URL: #41121
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This was referenced Dec 18, 2021
Open
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@ronag@danielleadams
stream: add isErrored helper
2568ac9
Refs: nodejs/undici#1134
PR-URL: #41121
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@ronag@danielleadams
stream: add isErrored helper
4522216
Refs: nodejs/undici#1134
PR-URL: #41121
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@JungMinuJungMinuJungMinu approved these changes
@jasnelljasnellAwaiting requested review from jasnell
@lpincalpincaAwaiting requested review from lpinca
@mscdexmscdexAwaiting requested review from mscdex
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@nodejs-github-bot@mscdex@lpinca@mcollina@JungMinu@aymen94