Uh oh!
There was an error while loading. Please reload this page.
meta: update AUTHORS - #41144
Merged
Merged
Conversation
Trott
requested changes
Dec 12, 2021
Trott
left a comment
Member
There was a problem hiding this comment.
Tierney's entry is a duplicate that needs a .mailmap entry addition instead.
lpinca
approved these changes
Dec 12, 2021
Contributor
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
commented
Dec 12, 2021
CollaboratorAuthor
Commit Queue failed- Loading data for nodejs/node/pull/41144 ✔ Done loading data for nodejs/node/pull/41144 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#41144) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, fast-track, commit-queue-squash Commits 2 - meta: update AUTHORS - fixup! meta: update AUTHORS Committers 2 - Node.js GitHub Bot - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41144 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41144 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Dec 2021 00:16:11 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41144#pullrequestreview-829579644 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41144#pullrequestreview-829660067 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1570247089 |
PR-URL: #41144 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trottforce-pushed
the
actions/authors-update
branch
from
December 12, 2021 23:49
2df2823 to
4d7dd6cCompareTrott
commented
Dec 12, 2021
Member
Landed in 4d7dd6c |
danielleadams pushed a commit
that referenced
this pull request
Dec 14, 2021
PR-URL: #41144 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #41144 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #41144 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41144 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some new additions to the AUTHORS file. This is an automatically generated PR by the
authors.ymlGitHub Action, which runstools/update-authors.js.