Skip to content

[v12.x] update to OpenSSL 1.1.1m - #41172

Closed
richardlau wants to merge 2 commits into
nodejs:v12.x-stagingfrom
richardlau:v12.x-openssl1.1.1m
Closed

[v12.x] update to OpenSSL 1.1.1m#41172
richardlau wants to merge 2 commits into
nodejs:v12.x-stagingfrom
richardlau:v12.x-openssl1.1.1m

Conversation

@richardlau

Copy link
Copy Markdown
Member

This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1m.tar.gz
$ mv openssl-1.1.1m openssl
$ git add --all openssl
$ git commit openssl
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/include/crypto/bn_conf.h
$ git add deps/openssl/openssl/include/crypto/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
@github-actionsgithub-actionsBot added needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v12.x labels Dec 14, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlaurichardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 14, 2021
@richardlau

Copy link
Copy Markdown
MemberAuthor

I stuck a fast track label on this as I'd like to include OpenSSL 1.1.1m in #41161. Please 👍 to approve, or remove the label if you disagree with fast tracking this.

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richardlau

Copy link
Copy Markdown
MemberAuthor

Landed in 243b2fb...4c9f920.

richardlau added a commit that referenced this pull request Dec 15, 2021
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1m.tar.gz
$ mv openssl-1.1.1m openssl
$ git add --all openssl
$ git commit openssl
PR-URL: #41172
Refs: https://mta.openssl.org/pipermail/openssl-announce/2021-December/000211.html
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
richardlau added a commit that referenced this pull request Dec 15, 2021
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/include/crypto/bn_conf.h
$ git add deps/openssl/openssl/include/crypto/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
PR-URL: #41172
Refs: https://mta.openssl.org/pipermail/openssl-announce/2021-December/000211.html
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@richardlau
richardlau deleted the v12.x-openssl1.1.1m branch December 15, 2021 17:22
@richardlaurichardlau mentioned this pull request Dec 15, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.opensslIssues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@richardlau@nodejs-github-bot@mcollina@tniessen