Uh oh!
There was an error while loading. Please reload this page.
url,lib: pass urlsearchparams-constructor.any.js - #41197
Closed
XadillaX wants to merge 1 commit into
Closed
Conversation
jasnell
reviewed
Dec 17, 2021
| } | ||
| getcode(){return'ERR_INVALID_THIS';} | ||
| functionthrowInvalidThisError(Base,type){ |
Member
There was a problem hiding this comment.
Is the change to domexception.js related to the urlsearchparams change? If it is, it's not clear how. Also, it would likely be better to separate this out into a separate commit in the PR if it is related.
ContributorAuthor
There was a problem hiding this comment.
This modification is to pass urlsearchparams-contructor.any.js too.
ContributorAuthor
There was a problem hiding this comment.
URLSearchParams constructor should throw exactly TypeError if any Error occurrs but not inheritance.
ContributorAuthor
There was a problem hiding this comment.
aduh95
reviewed
Dec 18, 2021
Uh oh!
There was an error while loading. Please reload this page.
XadillaXforce-pushed
the
urlsearchparams-constructor.any.js-2
branch
from
December 20, 2021 06:00
c2e77f2 to
c0a9720CompareAccording to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one.
XadillaXforce-pushed
the
urlsearchparams-constructor.any.js-2
branch
from
December 20, 2021 06:04
c0a9720 to
59e2c32CompareXadillaX
commented
Dec 23, 2021
ContributorAuthor
/ping @aduh95 |
XadillaX
commented
Dec 27, 2021
ContributorAuthor
@addaleax Hi Anna, would you please take a look at this PR? |
XadillaX
commented
Dec 27, 2021
ContributorAuthor
/cc @watilde |
Lxxyx
approved these changes
Dec 31, 2021
nodejs-github-bot
commented
Jan 4, 2022
Collaborator
This was referenced Jan 5, 2022
nodejs-github-bot
commented
Jan 11, 2022
Collaborator
nodejs-github-bot
commented
Jan 11, 2022
Collaborator
nodejs-github-bot
commented
Jan 11, 2022
Collaborator
nodejs-github-bot
commented
Jan 11, 2022
Collaborator
XadillaX added a commit
that referenced
this pull request
Jan 11, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: #41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
ContributorAuthor
Landed in 38b7961 |
aduh95
commented
Jan 11, 2022
Contributor
Did you mean: "Landed in 38b7961"? 😅 |
20 tasks
XadillaX
commented
Jan 12, 2022
ContributorAuthor
Yes. I think I copied the wrong text🙈 |
18 tasks
22 tasks
targos pushed a commit
that referenced
this pull request
Jan 14, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: #41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
26 tasks
targos pushed a commit
that referenced
this pull request
Jul 31, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: #41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
guangwong pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: nodejs/node#41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to WPT:
URLSearchParamsconstructor should throw exactlyTypeErrorif anyError occurrs.
URLSearchParamsconstructor, two differentkey may result same after
toUVString(). We should leave only thelater one.