Skip to content

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable - #41235

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
dsanders11:patch-1
Jan 6, 2022
Merged

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable#41235
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
dsanders11:patch-1

Conversation

@dsanders11

@dsanders11dsanders11 commented Dec 19, 2021•
edited by richardlau
Loading

Copy link
Copy Markdown
Contributor

Looks like VCBUILD_PYTHON_LOCATION went stale at some point, and isn't read anywhere (searching the repo shows this is the only usage).

Refs: #18621

@nodejs-github-botnodejs-github-bot added install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Dec 19, 2021
@dsanders11dsanders11 changed the title build,tools,win: Trim unused VCBUILD_PYTHON_LOCATION variablebuild,tools,win: trim unused VCBUILD_PYTHON_LOCATION variableDec 19, 2021
RaisinTen
RaisinTen approved these changes Dec 19, 2021
View reviewed changes

@RaisinTenRaisinTen left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses of VCBUILD_PYTHON_LOCATION were removed in #18621, LGTM.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2021
This was referenced Dec 20, 2021
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Dec 22, 2021
Open
Open
Open
Open
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Dec 28, 2021
Open
Open
Open
Open
Open
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Jan 4, 2022
Open
25 tasks
@github-actionsgithub-actionsBot mentioned this pull request Jan 5, 2022
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41757/

@RaisinTenRaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 79b21ee into nodejs:masterJan 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in 79b21ee

@dsanders11
dsanders11 deleted the patch-1 branch January 6, 2022 22:24
targos pushed a commit that referenced this pull request Jan 14, 2022
@dsanders11@targos
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
2233f31
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targostargos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@dsanders11@danielleadams
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
fc38d15
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@richardlaurichardlaurichardlau approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.installIssues and PRs related to the installers.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dsanders11@nodejs-github-bot@jasnell@richardlau@RaisinTen