Skip to content

esm: reconcile JSDoc vs. actual parameter name - #41238

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:esm-reconcile
Dec 21, 2021
Merged

esm: reconcile JSDoc vs. actual parameter name#41238
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:esm-reconcile

Conversation

@Trott

@TrottTrott commented Dec 19, 2021

Copy link
Copy Markdown
Member

No description provided.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 19, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 19, 2021

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules

@github-actions

github-actionsBot commented Dec 19, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Dec 19, 2021
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41571/

@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41579/

@TrottTrott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Dec 21, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2021
@nodejs-github-bot
nodejs-github-bot merged commit 23f1b22 into nodejs:masterDec 21, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

Landed in 23f1b22

@Trott
Trott deleted the esm-reconcile branch December 21, 2021 18:04
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott@targos
esm: reconcile JSDoc vs. actual parameter name
5ebe086
PR-URL: #41238
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targostargos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott@danielleadams
esm: reconcile JSDoc vs. actual parameter name
1cf5dbe
PR-URL: #41238
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
esm: reconcile JSDoc vs. actual parameter name
a0a8f4d
PR-URL: #41238
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@jasnell@BridgeAR@aduh95