Skip to content

test: correct param name in JSDoc comment - #41241

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
Trott:wpt-param
Dec 21, 2021
Merged

test: correct param name in JSDoc comment#41241
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
Trott:wpt-param

Conversation

@Trott

@TrottTrott commented Dec 19, 2021

Copy link
Copy Markdown
Member

No description provided.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 19, 2021
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 19, 2021
@github-actions

github-actionsBot commented Dec 19, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

aduh95
aduh95 approved these changes Dec 19, 2021
View reviewed changes
Comment threadtest/common/wpt.js Outdated
@Trott@aduh95
Update test/common/wpt.js
19fc7bf
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@TrottTrott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 19, 2021
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41568/

@TrottTrott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Dec 21, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2021
@nodejs-github-bot
nodejs-github-bot merged commit 0132db0 into nodejs:masterDec 21, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

Landed in 0132db0

@Trott
Trott deleted the wpt-param branch December 21, 2021 18:16
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott@targos
test: correct param name in JSDoc comment
8f08328
PR-URL: #41241
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott@danielleadams
test: correct param name in JSDoc comment
ffd829d
PR-URL: #41241
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
test: correct param name in JSDoc comment
8926d95
PR-URL: #41241
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@jasnell@aduh95