Skip to content

lib: fix consistency of methods that emit warnings - #41249

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
kuriyosh:dns-util-consistency
Jan 21, 2022
Merged

lib: fix consistency of methods that emit warnings#41249
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
kuriyosh:dns-util-consistency

Conversation

@kuriyosh

@kuriyoshkuriyosh commented Dec 20, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

For consistency, I refactored emitInvalidHostnameWarning method same logic as emitTypeCoercionDeprecationWarning.

@nodejs-github-bot

nodejs-github-bot commented Dec 20, 2021

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-botnodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels Dec 20, 2021
@watildewatilde added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41623/

@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2022
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42000/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot
nodejs-github-bot merged commit feafea1 into nodejs:masterJan 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in feafea1

BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@kuriyosh@BethGriggs
lib: fix consistency of methods that emit warnings
306dd1c
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@kuriyosh@danielleadams
lib: fix consistency of methods that emit warnings
13a3faa
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@kuriyosh@danielleadams
lib: fix consistency of methods that emit warnings
fc7c831
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@kuriyosh@danielleadams
lib: fix consistency of methods that emit warnings
9feab92
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@kuriyosh@danielleadams
lib: fix consistency of methods that emit warnings
0f3287d
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@watildewatildewatilde approved these changes
+1 more reviewer
@MesteeryMesteeryMesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dnsIssues and PRs related to the dns subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kuriyosh@nodejs-github-bot@jasnell@watilde@Mesteery@aduh95