Skip to content

test: mark test-worker-take-heapsnapshot flaky - #41253

Closed
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:arm-debug-1
Closed

test: mark test-worker-take-heapsnapshot flaky#41253
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:arm-debug-1

Conversation

@mhdawson

@mhdawsonmhdawson commented Dec 20, 2021

Copy link
Copy Markdown
Member
  • Mark test-worker-take-heapsnapshot as flaky on
    arm with debug

Refs: #41204
Refs: #41209

Signed-off-by: Michael Dawson mdawson@devrus.com

@mhdawson
test: mark test-worker-take-heapsnapshot flaky
85c96e3
- Mark test-worker-take-heapsnapshot as flaky on
arm with debug
Refs: nodejs#41204
Refs: nodejs#41209
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 20, 2021
@mhdawsonmhdawson mentioned this pull request Dec 20, 2021
Closed
@mhdawson

mhdawson commented Dec 21, 2021

Copy link
Copy Markdown
MemberAuthor

Would like to request a fast track on this.

@mhdawsonmhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2021
@github-actions

github-actionsBot commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41575/

cjihrig
cjihrig approved these changes Dec 21, 2021
View reviewed changes
Comment threadtest/pummel/pummel.status Outdated
@mhdawson@cjihrig
Update test/pummel/pummel.status
0d740ab
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41596/

@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41598/

@github-actionsgithub-actionsBot mentioned this pull request Dec 22, 2021
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41615/

@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41617/

@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41618/

mhdawson added a commit that referenced this pull request Dec 22, 2021
@mhdawson
test: mark test-worker-take-heapsnapshot flaky
96a6326
- Mark test-worker-take-heapsnapshot as flaky on
arm with debug
Refs: #41204
Refs: #41209
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson

mhdawson commented Dec 22, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 96a6326

This was referenced Dec 23, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 30, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 14, 2022
@mhdawson@targos
test: mark test-worker-take-heapsnapshot flaky
fac0871
- Mark test-worker-take-heapsnapshot as flaky on
arm with debug
Refs: #41204
Refs: #41209
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@mhdawson@danielleadams
test: mark test-worker-take-heapsnapshot flaky
55fb3d3
- Mark test-worker-take-heapsnapshot as flaky on
arm with debug
Refs: #41204
Refs: #41209
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson@danielleadams
test: mark test-worker-take-heapsnapshot flaky
a53399e
- Mark test-worker-take-heapsnapshot as flaky on
arm with debug
Refs: #41204
Refs: #41209
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41253
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhdawson@nodejs-github-bot@jasnell@cjihrig