Uh oh!
There was an error while loading. Please reload this page.
tools: use arrow function for callback in lint-sh.js - #41256
Merged
Conversation
The function declaration inside an else block is odd (and violates a recommended ESLint rule). We tend to use arrow functions for callbacks anyway, so switch to that.
aduh95
approved these changes
Dec 21, 2021
cjihrig
approved these changes
Dec 21, 2021
jasnell
approved these changes
Dec 21, 2021
Contributor
Fast-track has been requested by @jasnell. Please 👍 to approve. |
nodejs-github-bot
commented
Dec 22, 2021
Collaborator
Landed in 27c6fdf |
targos pushed a commit
that referenced
this pull request
Jan 14, 2022
The function declaration inside an else block is odd (and violates a recommended ESLint rule). We tend to use arrow functions for callbacks anyway, so switch to that. PR-URL: #41256 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 31, 2022
The function declaration inside an else block is odd (and violates a recommended ESLint rule). We tend to use arrow functions for callbacks anyway, so switch to that. PR-URL: #41256 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 1, 2022
The function declaration inside an else block is odd (and violates a recommended ESLint rule). We tend to use arrow functions for callbacks anyway, so switch to that. PR-URL: #41256 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function declaration inside an else block is odd (and violates a
recommended ESLint rule). We tend to use arrow functions for callbacks
anyway, so switch to that.