Skip to content

doc: fix sync comment in observer example - #41262

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
erj826:bug-perf-observer-snippet-async
Dec 27, 2021
Merged

doc: fix sync comment in observer example#41262
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
erj826:bug-perf-observer-snippet-async

Conversation

@erj826

@erj826erj826 commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Updates doc comment here since the PerformanceObserver callback is always called asynchronously.

Refs: #41259

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Dec 21, 2021
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2021
@github-actions

github-actionsBot commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@erj826

erj826 commented Dec 27, 2021

Copy link
Copy Markdown
ContributorAuthor

Anything else I need to do to get this across the finish line?

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2021
@nodejs-github-bot
nodejs-github-bot merged commit d34fcb6 into nodejs:masterDec 27, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

Landed in d34fcb6

targos pushed a commit that referenced this pull request Jan 14, 2022
@erj826@targos
doc: fix sync comment in observer snippet
5cfc547
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@targostargos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@erj826@danielleadams
doc: fix sync comment in observer snippet
cc4df85
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@erj826@danielleadams
doc: fix sync comment in observer snippet
1c0c140
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@HarshithaKPHarshithaKPHarshithaKP approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.perf_hooksIssues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erj826@nodejs-github-bot@jasnell@lpinca@HarshithaKP@VoltrexKeyva