Skip to content

build: start build on z/OS - #41273

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
ibmruntimes:upstreammaster
Jan 6, 2022
Merged

build: start build on z/OS#41273
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
ibmruntimes:upstreammaster

Conversation

@alexcfyung

Copy link
Copy Markdown
Contributor

Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.

Just with this commit node.js won't build on z/OS as it just start the build.
This will be the first pr to upstream z/OS changes.

Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Co-authored-by: Wayne Zhang <zsw007@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Dec 21, 2021
@richardlau

Copy link
Copy Markdown
Member

cc @nodejs/build-files @nodejs/platform-zos

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlaurichardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit f6e5050 into nodejs:masterJan 6, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in f6e5050

targos pushed a commit that referenced this pull request Jan 14, 2022
Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Co-authored-by: Wayne Zhang <zsw007@gmail.com>
PR-URL: #41273
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
@targostargos mentioned this pull request Jan 16, 2022
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.
Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Co-authored-by: Wayne Zhang <zsw007@gmail.com>
PR-URL: #41273
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcfyung@nodejs-github-bot@richardlau@mhdawson@ryzokuken