Skip to content

events: add jsdoc details for Event and EventTarget - #41274

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:eventtarget-jsdocs
Closed

events: add jsdoc details for Event and EventTarget#41274
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:eventtarget-jsdocs

Conversation

@jasnell

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 21, 2021
Comment threadlib/internal/event_target.js Outdated
Co-authored-by: Rich Trott <rtrott@gmail.com>
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Dec 21, 2021
jasnell added a commit that referenced this pull request Dec 24, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 9d6bd10

@jasnelljasnell closed this Dec 24, 2021
targos pushed a commit that referenced this pull request Jan 14, 2022
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@targostargos mentioned this pull request Jan 16, 2022
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #41274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@Trott@edsadr@benjamingr@aduh95@nodejs-github-bot