Skip to content

async_hooks: add missing initialization - #41288

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
mhdawson:coverity-8
Dec 25, 2021
Merged

async_hooks: add missing initialization#41288
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
mhdawson:coverity-8

Conversation

@mhdawson

@mhdawsonmhdawson commented Dec 22, 2021

Copy link
Copy Markdown
Member
  • Add missing initialization reported by coverity.

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 22, 2021
@mhdawson
async_hooks: add missing initialization
0a651ca
- Add missing initialization reported by coverity.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawsonmhdawson changed the title async_wrap: add missing initializationasync_hooks: add missing initializationDec 22, 2021
mcollina
mcollina approved these changes Dec 23, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Dec 24, 2021
Open
18 tasks
@github-actionsgithub-actionsBot mentioned this pull request Dec 25, 2021
Open
19 tasks
@FlarnaFlarna added the async_hooks Issues and PRs related to the async hooks subsystem. label Dec 25, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41650/

@FlarnaFlarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2021
@nodejs-github-bot
nodejs-github-bot merged commit ffa00fa into nodejs:masterDec 25, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 25, 2021

Copy link
Copy Markdown
Collaborator

Landed in ffa00fa

This was referenced Dec 26, 2021
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 3, 2022
Open
Open
targos pushed a commit that referenced this pull request Jan 14, 2022
@mhdawson@targos
async_hooks: add missing initialization
314102b
- Add missing initialization reported by coverity.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41288
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@targostargos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@mhdawson@danielleadams
async_hooks: add missing initialization
ecb5d37
- Add missing initialization reported by coverity.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41288
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson@danielleadams
async_hooks: add missing initialization
f788a47
- Add missing initialization reported by coverity.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41288
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes
@JungMinuJungMinuJungMinu approved these changes
@FlarnaFlarnaFlarna approved these changes

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mhdawson@nodejs-github-bot@mcollina@jasnell@lpinca@tniessen@JungMinu@Flarna