Skip to content

readline: add features yank and yank pop - #41301

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
rayw000:feature-yank
Jan 22, 2022
Merged

readline: add features yank and yank pop#41301
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
rayw000:feature-yank

Conversation

@rayw000

@rayw000rayw000 commented Dec 23, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor
  1. New features yank and yank pop
  2. Unit tests for the new features
  3. Document the new features

Fixes: #41252

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Dec 23, 2021
jasnell
jasnell reviewed Dec 23, 2021
View reviewed changes
Comment threadlib/internal/readline/interface.js Outdated
jasnell
jasnell reviewed Dec 23, 2021
View reviewed changes
Comment threadlib/internal/readline/interface.js Outdated
@jasnell

jasnell commented Dec 23, 2021

Copy link
Copy Markdown
Member

+1 to adding this. Needs tests and doc updates also tho

@jasnelljasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 23, 2021
@rayw000

rayw000 commented Dec 23, 2021

Copy link
Copy Markdown
ContributorAuthor

+1 to adding this. Needs tests and doc updates also tho

No problem. I'll update tomorrow.

@rayw000rayw000 changed the title repl: add feature yank and yank popreadline: add feature yank and yank popDec 24, 2021
@rayw000
rayw000 requested a review from jasnellDecember 24, 2021 04:25
VoltrexKeyva
VoltrexKeyva reviewed Dec 24, 2021
View reviewed changes
Comment threadlib/internal/readline/interface.js Outdated
@rayw000rayw000 changed the title readline: add feature yank and yank popreadline: add features yank and yank popDec 24, 2021
jasnell
jasnell reviewed Jan 17, 2022
View reviewed changes
Comment threaddoc/api/readline.md Outdated
@rayw000

rayw000 commented Jan 18, 2022

Copy link
Copy Markdown
ContributorAuthor

This PR and #41392 are conflicting. Once one of them is accepted, I'll update the other.

@rayw000rayw000 mentioned this pull request Jan 18, 2022
Merged
@Ayase-252Ayase-252 added the blocked PRs that are blocked by other issues or PRs. label Jan 21, 2022
@Ayase-252

Ayase-252 commented Jan 21, 2022

Copy link
Copy Markdown
Member

Blocked on #41392

@Ayase-252Ayase-252 removed the blocked PRs that are blocked by other issues or PRs. label Jan 21, 2022
@Ayase-252

Ayase-252 commented Jan 21, 2022

Copy link
Copy Markdown
Member

#41392 was merged. Unblocked

@rayw000
readline: add feature yank and yank pop
d7204be
1. `Ctrl-Y` to yank previously deleted text
2. `Meta-Y` to do yank pop (cycle among deleted texts)
3. Use `getCursorPos().rows` to check if we have reached a new line,
instead of `getCursorPos().cols === 0`.
4. document and unittests.
@Ayase-252Ayase-252 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42068/

@github-actionsgithub-actionsBot mentioned this pull request Jan 22, 2022
Open
17 tasks
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42077/

@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42078/

@Ayase-252Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 22, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2f17004 into nodejs:masterJan 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2f17004

@rayw000
rayw000 deleted the feature-yank branch January 22, 2022 10:57
This was referenced Jan 23, 2022
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@rayw000@BethGriggs
readline: add feature yank and yank pop
0a31149
1. `Ctrl-Y` to yank previously deleted text
2. `Meta-Y` to do yank pop (cycle among deleted texts)
3. Use `getCursorPos().rows` to check if we have reached a new line,
instead of `getCursorPos().cols === 0`.
4. document and unittests.
PR-URL: #41301Fixes: #41252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@github-actionsgithub-actionsBot mentioned this pull request Jan 26, 2022
Open
26 tasks
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
@danielleadams

danielleadams commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

@rayw000 do you mind backporting this to v16.x? When landing the PR, it breaks tests.

@rayw000

rayw000 commented Apr 11, 2022

Copy link
Copy Markdown
ContributorAuthor

@rayw000 do you mind backporting this to v16.x? When landing the PR, it breaks tests.

Hi @danielleadams

This PR relies on #37947, which is similar to #41392. It may not be appropriate to backport #37947 since it is a semver major change.

@danielleadams

danielleadams commented Apr 11, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

@rayw000 no problem - I'll mark as don't-land-to-v16.x. Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@Ayase-252Ayase-252Ayase-252 approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.readlineIssues and PRs related to the built-in readline module.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Only Ctrl-Y yank doesn't work in REPL

6 participants

@rayw000@jasnell@Ayase-252@nodejs-github-bot@danielleadams@VoltrexKeyva