Uh oh!
There was an error while loading. Please reload this page.
test: mark test-repl-sigint-nested-eval as flaky - #41302
Closed
mhdawson wants to merge 1 commit into
Closed
Conversation
Refs: nodejs#41123 - This is one of the remaining high occurance flaky tests from the reliability reports and recent failures in the CI. Mark as flaky until issue is resolved under referenced issue. Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson
commented
Dec 23, 2021
MemberAuthor
Would like to request fast track for this. |
Contributor
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
nodejs-github-bot
commented
Dec 23, 2021
Collaborator
lpinca
approved these changes
Dec 23, 2021
| [true] # This section applies to all platforms | ||
| # https://github.com/nodejs/node/issues/41123 | ||
| test-repl-sigint-nested-eval: PASS, FLAKY |
Member
There was a problem hiding this comment.
The test is skipped on Windows, but it is easier to do this than repeating the same stuff on all other supported platforms, so I have no objections.
nodejs-github-bot
commented
Dec 23, 2021
Collaborator
This was referenced Dec 24, 2021
This was referenced Dec 31, 2021
nodejs-github-bot
commented
Jan 4, 2022
Collaborator
nodejs-github-bot
commented
Jan 4, 2022
Collaborator
mhdawson added a commit
that referenced
this pull request
Jan 4, 2022
Refs: #41123 - This is one of the remaining high occurance flaky tests from the reliability reports and recent failures in the CI. Mark as flaky until issue is resolved under referenced issue. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41302 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
mhdawson
commented
Jan 4, 2022
MemberAuthor
Landed in c85e67b |
This was referenced Jan 5, 2022
This was referenced Jan 9, 2022
targos pushed a commit
that referenced
this pull request
Jan 14, 2022
Refs: #41123 - This is one of the remaining high occurance flaky tests from the reliability reports and recent failures in the CI. Mark as flaky until issue is resolved under referenced issue. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41302 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 31, 2022
Refs: #41123 - This is one of the remaining high occurance flaky tests from the reliability reports and recent failures in the CI. Mark as flaky until issue is resolved under referenced issue. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41302 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 1, 2022
Refs: #41123 - This is one of the remaining high occurance flaky tests from the reliability reports and recent failures in the CI. Mark as flaky until issue is resolved under referenced issue. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41302 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #41123
tests from the reliability reports and recent
failures in the CI. Mark as flaky until issue
is resolved under referenced issue.
Signed-off-by: Michael Dawson mdawson@devrus.com