Uh oh!
There was an error while loading. Please reload this page.
doc: improve strictly - #4138
Closed
yorkie wants to merge 1 commit into
Closed
Conversation
cjihrig
commented
Dec 3, 2015
Contributor
LGTM |
Contributor
There was a problem hiding this comment.
Double space after period is not significant in rendered markdown and we use it in a few other places. Maybe leave out this change?
jasnell
commented
Dec 3, 2015
Member
LGTM |
yorkie
commented
Dec 3, 2015
ContributorAuthor
Removed the double spaces change and did resolve the conflicts :-) |
JungMinu
commented
Dec 4, 2015
Member
LGTM |
jasnell pushed a commit
that referenced
this pull request
Dec 4, 2015
PR-URL: #4138 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Dec 4, 2015
Member
Landed in cc2ceb6 @yorkie ... I notice that in your commits, your name appears just as "yorkie". Is that how you would like your name to appear in the commit history or would you like your full name "Yorkie Liu" displayed? If you'd like your full name listed, can I ask you to run |
yorkie
commented
Dec 5, 2015
ContributorAuthor
@jasnell the nickname "yorkie" is good to me, thank you. |
rvagg pushed a commit
that referenced
this pull request
Dec 5, 2015
PR-URL: #4138 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 8, 2015
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 29, 2015
PR-URL: #4138 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 19, 2016
PR-URL: #4138 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4138 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Mar 18, 2020
This was referenced Mar 18, 2020
This was referenced Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just improve this document when reading it :-)