Skip to content

doc: feature management proposal - #41420

Closed
mhdawson wants to merge 4 commits into
nodejs:masterfrom
mhdawson:features
Closed

doc: feature management proposal#41420
mhdawson wants to merge 4 commits into
nodejs:masterfrom
mhdawson:features

Conversation

@mhdawson

@mhdawsonmhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 6, 2022
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
VoltrexKeyva
VoltrexKeyva reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
Comment threaddoc/guides/feature-request-management.md Outdated
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
@Trott

Trott commented Jan 7, 2022

Copy link
Copy Markdown
Member

If we're going to add a doc like this, we'll probably want to include a link to it in https://github.com/nodejs/node/blob/master/.github/ISSUE_TEMPLATE/2-feature-request.yml.

mhdawson
mhdawson commented Jan 7, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
@mhdawson

mhdawson commented Jan 7, 2022

Copy link
Copy Markdown
MemberAuthor

@mscdex@bnb@aduh95@Trott thanks for all the comments. I think I've addressed them all.

aduh95
aduh95 reviewed Jan 7, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated
Comment threaddoc/guides/feature-request-management.md Outdated
@mhdawsonmhdawson mentioned this pull request Jan 13, 2022
Closed
jasnell
jasnell reviewed Jan 17, 2022
View reviewed changes
Comment threaddoc/guides/feature-request-management.md Outdated

@jasnelljasnellJan 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these line lengths so short? :-P

@mhdawsonmhdawsonJan 18, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer that to having to check each one for being too long :)

@Mesteery

Mesteery commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Should this be moved to doc/contributing instead of doc/guides?

@mhdawson

mhdawson commented Jan 20, 2022

Copy link
Copy Markdown
MemberAuthor

@Mesteery not that the other PR has landed this does need a "rebase"

@mhdawson
doc: feature management proposal
142caa2
Refs: https://github.com/nodejs/node/discussions/40823
Refs: nodejs#41113
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson

mhdawson commented Jan 24, 2022

Copy link
Copy Markdown
MemberAuthor

@Mesteery moved.

@mhdawson

mhdawson commented Jan 28, 2022

Copy link
Copy Markdown
MemberAuthor

@targos just wondering if you'd had a chance to consider what updates we might make to this in order to incorporate your suggestion about using Node.js feature requests

@targos

targos commented Jan 29, 2022

Copy link
Copy Markdown
Member

@mhdawson I think this PR doesn't have to wait for this project. I'm convinced that it will be useful but I need to discuss with other people before documenting it.

@mhdawson

mhdawson commented Jan 31, 2022

Copy link
Copy Markdown
MemberAuthor

@targos thanks. @nodejs/tsc it would be good to have a few more approvals since once this lands I'll work to turn on stale bot and we'll have some issues tagged feature being closed as outline in the process.

Trott
Trott reviewed Feb 1, 2022
View reviewed changes
Comment thread.github/ISSUE_TEMPLATE/2-feature-request.yml Outdated
@mhdawson@Trott
Update .github/ISSUE_TEMPLATE/2-feature-request.yml
467d1b6
Co-authored-by: Rich Trott <rtrott@gmail.com>
RaisinTen
RaisinTen approved these changes Feb 1, 2022
View reviewed changes

@RaisinTenRaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: HEAD links :)

Comment threaddoc/contributing/feature-request-management.md Outdated
Comment threaddoc/contributing/feature-request-management.md Outdated
mhdawsonand others added 2 commits February 1, 2022 17:34
@mhdawson@RaisinTen
Update doc/contributing/feature-request-management.md
a378978
Co-authored-by: Darshan Sen <raisinten@gmail.com>
@mhdawson@RaisinTen
Update doc/contributing/feature-request-management.md
da1e6a4
Co-authored-by: Darshan Sen <raisinten@gmail.com>
mcollina
mcollina approved these changes Feb 2, 2022
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawson

mhdawson commented Feb 3, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Agreed in last weeks TSC meeting on actions, does still need to be on agenda? - Wrong PR

mhdawson added a commit that referenced this pull request Feb 4, 2022
@mhdawson
doc: feature management proposal
6c0eb94
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@mhdawson

mhdawson commented Feb 4, 2022

Copy link
Copy Markdown
MemberAuthor

Landed in 6c0eb94

@mhdawsonmhdawson closed this Feb 4, 2022
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@mhdawson@ruyadorno
doc: feature management proposal
451f333
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@mhdawson@danielleadams
doc: feature management proposal
1334f61
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@mhdawson@danielleadams
doc: feature management proposal
8567aff
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@mhdawson@danielleadams
doc: feature management proposal
6be94bf
Refs: https://github.com/nodejs/node/discussions/40823
Refs: nodejs#41113
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@mhdawson@danielleadams
doc: feature management proposal
4472527
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@mhdawson@danielleadams
doc: feature management proposal
c742a1c
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbbnbbnb left review comments
@TrottTrottTrott left review comments
@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@aduh95aduh95aduh95 approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+3 more reviewers
@mscdexmscdexmscdex left review comments
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
@mmarchinimmarchinimmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

14 participants

@mhdawson@Trott@Mesteery@targos@mcollina@mscdex@jasnell@bnb@mmarchini@gireeshpunathil@aduh95@RaisinTen@VoltrexKeyva@nodejs-github-bot