Uh oh!
There was an error while loading. Please reload this page.
stream: fix error-path function call - #41433
Merged
Merged
Conversation
The `onFinish()` function takes a single argument. The two extra arguments passed here are already in the function scope, and may result in the error being mishandled.
nodejs-github-bot
commented
Jan 7, 2022
Collaborator
Review requested:
|
This comment has been minimized.
This comment has been minimized.
ronag
approved these changes
Jan 7, 2022
lpinca
approved these changes
Jan 7, 2022
apapirovski
approved these changes
Jan 7, 2022
nodejs-github-bot
commented
Jan 8, 2022
Collaborator
benjamingr
approved these changes
Jan 8, 2022
VoltrexKeyva
approved these changes
Jan 8, 2022
Trott
commented
Jan 11, 2022
MemberAuthor
Based on https://coverage.nodejs.org/coverage-f17b73cebd82babe/lib/internal/streams/writable.js.html#L715, it appears that the line of code in question here is not tested at all. 😳 |
nodejs-github-bot
commented
Jan 11, 2022
Collaborator
Landed in 8c3637c |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jan 12, 2022
targos pushed a commit
that referenced
this pull request
Jan 14, 2022
The `onFinish()` function takes a single argument. The two extra arguments passed here are already in the function scope, and may result in the error being mishandled. PR-URL: #41433 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
nodejs-github-bot pushed a commit
that referenced
this pull request
Jan 17, 2022
Refs: #41433 (comment) PR-URL: #41486 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Jan 25, 2022
Refs: #41433 (comment) PR-URL: #41486 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 1, 2022
The `onFinish()` function takes a single argument. The two extra arguments passed here are already in the function scope, and may result in the error being mishandled. PR-URL: #41433 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onFinish()function takes a single argument. The two extraarguments passed here are already in the function scope, and may result
in the error being mishandled.