Skip to content

doc: fixup my mailmap entries - #41437

Merged
Trott merged 1 commit into
nodejs:masterfrom
mhdawson:fixup-mailmap
Jan 11, 2022
Merged

doc: fixup my mailmap entries#41437
Trott merged 1 commit into
nodejs:masterfrom
mhdawson:fixup-mailmap

Conversation

@mhdawson

@mhdawsonmhdawson commented Jan 7, 2022

Copy link
Copy Markdown
Member

Fixup the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 7, 2022
bnb
bnb approved these changes Jan 7, 2022
View reviewed changes
richardlau
richardlau reviewed Jan 7, 2022
View reviewed changes
Comment thread.mailmap Outdated
bnb
bnb requested changes Jan 7, 2022
View reviewed changes

@bnbbnb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formally requesting changes based on @richardlau's feedback :)

@mhdawson

mhdawson commented Jan 10, 2022

Copy link
Copy Markdown
MemberAuthor

@bnb fixed.

bnb
bnb approved these changes Jan 10, 2022
View reviewed changes
Trott
Trott requested changes Jan 11, 2022
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in duplicate entries in AUTHORS.

@Trott

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member

This will result in duplicate entries in AUTHORS.

Oh, wait, no it won't. This is good. You probably want to run tools/update-authors.js (and then maybe trim off any new authors it adds at the end--probably best to leave that for a separate PR from the weekly job) to update your entry in AUTHORS. Or you can wait for the automated job to do that, I guess.

@Trott

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member

Oh, wait, no it won't. This is good. You probably want to run tools/update-authors.js (and then maybe trim off any new authors it adds at the end--probably best to leave that for a separate PR from the weekly job) to update your entry in AUTHORS. Or you can wait for the automated job to do that, I guess.

We can kick off the weekly/automated job manually, so let's land this.

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2022
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 11, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@TrottTrott added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 11, 2022
@mhdawson@Trott
doc: update mailmap entries for mhdawson
02abe5c
Update the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#41437
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member

Landed in 02abe5c

@Trott
Trott merged commit 02abe5c into nodejs:masterJan 11, 2022
targos pushed a commit that referenced this pull request Jan 14, 2022
@mhdawson@targos
doc: update mailmap entries for mhdawson
524103d
Update the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41437
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson@danielleadams
doc: update mailmap entries for mhdawson
30cb694
Update the content and order of my mailmap entries. Recent
changelogs have been using my outdated email address.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41437
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbbnbbnb approved these changes
@TrottTrottTrott approved these changes
@richardlaurichardlaurichardlau approved these changes
+2 more reviewers
@edsadredsadredsadr approved these changes
@DerekNonGenericDerekNonGenericDerekNonGeneric approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mhdawson@Trott@nodejs-github-bot@bnb@edsadr@richardlau@DerekNonGeneric