Skip to content

doc: document flow for supporting type generation - #41464

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:doc-types-approach
Closed

doc: document flow for supporting type generation#41464
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:doc-types-approach

Conversation

@mhdawson

@mhdawsonmhdawson commented Jan 10, 2022

Copy link
Copy Markdown
Member

Refs: nodejs/next-10#104

Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.

Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 10, 2022
@mhdawsonmhdawson mentioned this pull request Jan 10, 2022
Closed
5 tasks
VoltrexKeyva
VoltrexKeyva reviewed Jan 11, 2022
View reviewed changes
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
HarshithaKP
HarshithaKP reviewed Jan 11, 2022
View reviewed changes
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
@mhdawson

mhdawson commented Jan 14, 2022

Copy link
Copy Markdown
MemberAuthor

@HarshithaKP, @VoltrexMaster thanks for the fixes, all incorporated.

@mhdawson

mhdawson commented Jan 17, 2022

Copy link
Copy Markdown
MemberAuthor

@targos, @bnb, @legendecas since you were at the summit could you review/approve if this captures what was agreed?

targos
targos approved these changes Jan 19, 2022
View reviewed changes
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
Mesteery
Mesteery reviewed Jan 19, 2022
View reviewed changes

@MesteeryMesteery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved to doc/contributing instead of doc/guides?

Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
Comment threaddoc/guides/maintaining-types-for-nodejs.md Outdated
@mhdawson

mhdawson commented Jan 20, 2022

Copy link
Copy Markdown
MemberAuthor

@Mesteery suggestions incorporated.

@mhdawson
doc: document flow for supporting type generation
8016c72
Refs: nodejs/next-10#104
Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.
Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson

mhdawson commented Jan 24, 2022

Copy link
Copy Markdown
MemberAuthor

@Mesteery rebased so doc is in right place now.

mhdawson added a commit that referenced this pull request Jan 25, 2022
@mhdawson
doc: document flow for supporting type generation
670dbba
Refs: nodejs/next-10#104
Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.
Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@mhdawson

mhdawson commented Jan 25, 2022

Copy link
Copy Markdown
MemberAuthor

Landed in 670dbba

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@mhdawson@ruyadorno
doc: document flow for supporting type generation
0ee468d
Refs: nodejs/next-10#104
Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.
Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@mhdawson@danielleadams
doc: document flow for supporting type generation
dfbe567
Refs: nodejs/next-10#104
Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.
Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@mhdawson@danielleadams
doc: document flow for supporting type generation
36ccb62
Refs: nodejs/next-10#104
Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.
Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@mhdawson@danielleadams
doc: document flow for supporting type generation
b63fb0f
Refs: nodejs/next-10#104
Add initial doc to capture how the project supports
the flow for types generation. Based on discussions
from the Next-10 mini-summit that included project
members and members of the Definitely Typed team.
Will need to be updated as we improve the flow and
resulting json but captures the current flow and
approach and will give us the place where we can
update as things change.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HarshithaKPHarshithaKPHarshithaKP left review comments
@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@legendecaslegendecaslegendecas approved these changes
+2 more reviewers
@MesteeryMesteeryMesteery left review comments
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mhdawson@jasnell@targos@legendecas@HarshithaKP@Mesteery@VoltrexKeyva@nodejs-github-bot