crypto: adjust types for getRandomValues

[LiviaMedeiros]

Fixes: #41480

Prevents Web Crypto API's getRandomValues from accepting DataView

WIP/draft at this moment.

I'm not sure if new DataView(buf.buffer) in this test was intentional:

node/test/parallel/test-webcrypto-random.js

Lines 47 to 53 in 6b7b0b7

	{
	constbuf=newUint16Array(10);
	constbefore=Buffer.from(buf).toString('hex');
	getRandomValues(newDataView(buf.buffer));
	constafter=Buffer.from(buf).toString('hex');
	assert.notStrictEqual(before,after);
	}

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[lpinca]

@LiviaMedeiros If this is ready (it seems so) please remove the draft status, otherwise CI does not run. Thank you.

[LiviaMedeiros]

Sure, now it's ready.

Also I should explicitly mention that this is a potentially breaking change, if someone actually uses this method with DataView.
Such usage is unlikely; but it's a part of public API and current documentation allows that.

[lpinca]

The Web Crypto API is experimental so I do not think we should label this as "semver-major". Can you please also update the doc to remove the no longer supported types?

[LiviaMedeiros]

That's great.
Updated the doc.

Raw ArrayBuffer from previous version wasn't acceptable and didn't work:

crypto.getRandomValues(newArrayBuffer(8));// DOMException [TypeMismatchError]

[LiviaMedeiros]

Rebased to make linter happy, updated list of jsGlobalTypes to make type parser happy.
If the union type looks too pedantic and ugly, it may be reduced to just {Buffer|TypedArray}.
But technically even Buffer is redundant, since its prototype is Uint8Array; and it would require an explicit warning about Float32Array and Float64Array anyway.

[DerekNonGeneric]

@LiviaMedeiros, thank you so much for this PR!

Did a light review, so pre-approving for now, but hope that we can get a more thorough review on this by other collaborators more involved in these parts — would like to see if further improvements can be made here. :)

[tniessen]

Thanks @LiviaMedeiros :)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/42082/

[panva]

Landed in b8de7aa