Uh oh!
There was an error while loading. Please reload this page.
doc: fix typos in esm.md - #41499
Merged
Merged
Conversation
nodejs-github-bot
commented
Jan 13, 2022
Collaborator
Review requested:
|
guybedford
approved these changes
Jan 13, 2022
tniessen
approved these changes
Jan 13, 2022
edsadr
approved these changes
Jan 13, 2022
yu521088
commented
Jan 14, 2022
ContributorAuthor
@guybedford By the way, in PACKAGE_RESOLVE method step 11.1, i thought packageURL should be:
Instead of:
Is this another typo? Take code from package.md as an example: // ./node_modules/es-module-package/package.json
{
"exports": {
"./features/*": "./src/features/*.js"
},
"imports": {
"#internal/*": "./src/internal/*.js"
}
}importfeatureYfrom'es-module-package/features/y/y';// Loads ./node_modules/es-module-package/src/features/y/y.jsIf concatenated "node_modules/" with packageSpecifier, the packageURL will initially be "./node_modules/es-module-package/src/features/y/y", though according to the loop, it will finally locate packageURL to "./node_modules/es-module-package", but it's a waste of time doing meaningless loop for "src/features/y" path. |
guybedford
commented
Jan 14, 2022
Contributor
@yu521088 well spotted, yes that is another typo! |
nodejs-github-bot
commented
Jan 17, 2022
Collaborator
Landed in f458f1b |
BethGriggs pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #41499 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 26, 2022
PR-URL: #41499 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc: fix typos in esm.md
Update the logic of LOOKUP_PACKAGE_SCOPE method step 2.3:
The pjsonURL should be
instead of
Because packageURL should be
undefinednow.