Uh oh!
There was an error while loading. Please reload this page.
doc: adjust assignment in condition in stream doc - #41510
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Trottforce-pushed
the
stream-no-cond-assign
branch
from
January 14, 2022 15:00
e458311 to
04c0a04CompareThis is part of an effort to get our code to comply with ESLint no-cond-assign so that we don't have to disable that rule in our config.
Trottforce-pushed
the
stream-no-cond-assign
branch
from
January 14, 2022 15:01
04c0a04 to
89db1feCompareaduh95
approved these changes
Jan 17, 2022
nodejs-github-bot
commented
Jan 17, 2022
Collaborator
Landed in 8cba65f |
BethGriggs pushed a commit
that referenced
this pull request
Jan 25, 2022
This is part of an effort to get our code to comply with ESLint no-cond-assign so that we don't have to disable that rule in our config. PR-URL: #41510 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 26, 2022
This is part of an effort to get our code to comply with ESLint no-cond-assign so that we don't have to disable that rule in our config. PR-URL: #41510 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to get our code to comply with ESLint
no-cond-assign so that we don't have to disable that rule in our config.