Uh oh!
There was an error while loading. Please reload this page.
[v16.x backport] deps: update ICU to 70.1 - #41525
Closed
targos wants to merge 2 commits into
Closed
Conversation
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1 PR-URL: nodejs#40658 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Do not ask to separate the changes in deps/icu-small and in the LICENSE file. Do not ask to remove the whitespace changes. The way commits are landed now doesn't eliminate them anymore. PR-URL: nodejs#40658 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nodejs-github-bot
commented
Jan 14, 2022
Collaborator
Review requested:
|
nodejs-github-bot
commented
Jan 14, 2022
Collaborator
nodejs-github-bot
commented
Jan 14, 2022
Collaborator
richardlau
approved these changes
Jan 14, 2022
26 tasks
nodejs-github-bot
commented
Jan 15, 2022
Collaborator
nodejs-github-bot
commented
Jan 17, 2022
Collaborator
Collaborator
16 tasks
targos
commented
Jan 18, 2022
MemberAuthor
Landed in 0466400...ab28dc5 |
targos added a commit
that referenced
this pull request
Jan 18, 2022
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1 PR-URL: #40658 Backport-PR-URL: #41525 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos added a commit
that referenced
this pull request
Jan 18, 2022
Do not ask to separate the changes in deps/icu-small and in the LICENSE file. Do not ask to remove the whitespace changes. The way commits are landed now doesn't eliminate them anymore. PR-URL: #40658 Backport-PR-URL: #41525 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clean cherry-pick of #40658
Opened as a PR to check CI.