Uh oh!
There was an error while loading. Please reload this page.
test: add coverage for util.inspect() - #41527
Merged
Merged
Conversation
benjamingr
approved these changes
Jan 14, 2022
aduh95
approved these changes
Jan 14, 2022
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Jan 14, 2022
VoltrexKeyva
approved these changes
Jan 14, 2022
This comment has been minimized.
This comment has been minimized.
26 tasks
tniessen
approved these changes
Jan 15, 2022
nodejs-github-bot
commented
Jan 15, 2022
Collaborator
nodejs-github-bot
commented
Jan 16, 2022
Collaborator
nodejs-github-bot
commented
Jan 16, 2022
Collaborator
nodejs-github-bot
commented
Jan 17, 2022
Collaborator
nodejs-github-bot
commented
Jan 17, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41527 ✔ Done loading data for nodejs/node/pull/41527 ----------------------------------- PR info ------------------------------------ Title test: add coverage for util.inspect() (#41527) Author Rich Trott (@Trott) Branch Trott:negative -> nodejs:master Labels test, author ready, needs-ci Commits 1 - test: add coverage for util.inspect() Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41527 Refs: https://coverage.nodejs.org/coverage-df507758e6c35534/lib/internal/util/inspect.js.html#L1463 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41527 Refs: https://coverage.nodejs.org/coverage-df507758e6c35534/lib/internal/util/inspect.js.html#L1463 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Jan 2022 16:26:53 GMT ✔ Approvals: 5 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41527#pullrequestreview-853119001 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41527#pullrequestreview-853174255 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41527#pullrequestreview-853357370 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41527#pullrequestreview-853455436 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41527#pullrequestreview-853494108 ✖ GitHub CI is still running ℹ Last Full PR CI on 2022-01-17T03:10:48Z: https://ci.nodejs.org/job/node-test-pull-request/41932/ - Querying data for job/node-test-pull-request/41932/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1706434968 |
Coverage stats indicate that there is no coverage for util.inspect() with a negative number and a numeric separator. Add a test case. Refs: https://coverage.nodejs.org/coverage-df507758e6c35534/lib/internal/util/inspect.js.html#L1463 PR-URL: nodejs#41527 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Trott
commented
Jan 17, 2022
MemberAuthor
Landed in 0594577 |
16 tasks
13 tasks
BethGriggs pushed a commit
that referenced
this pull request
Jan 25, 2022
Coverage stats indicate that there is no coverage for util.inspect() with a negative number and a numeric separator. Add a test case. Refs: https://coverage.nodejs.org/coverage-df507758e6c35534/lib/internal/util/inspect.js.html#L1463 PR-URL: #41527 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit
that referenced
this pull request
Feb 26, 2022
Coverage stats indicate that there is no coverage for util.inspect() with a negative number and a numeric separator. Add a test case. Refs: https://coverage.nodejs.org/coverage-df507758e6c35534/lib/internal/util/inspect.js.html#L1463 PR-URL: #41527 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage stats indicate that there is no coverage for util.inspect()
with a negative number and a numeric separator. Add a test case.
Refs: https://coverage.nodejs.org/coverage-df507758e6c35534/lib/internal/util/inspect.js.html#L1463