Uh oh!
There was an error while loading. Please reload this page.
stream: avoid function call where possible - #41534
Merged
Merged
Conversation
Instead of assigning a boolean, move the function call that assigns a value to the boolean to the only place that boolean is checked. This avoids the function call in cases where it is not needed. Refs: nodejs#41488 (review)
nodejs-github-bot
commented
Jan 15, 2022
Collaborator
Review requested:
|
Trott
commented
Jan 15, 2022
MemberAuthor
@nodejs/streams @aduh95 |
This comment has been minimized.
This comment has been minimized.
tniessen
approved these changes
Jan 15, 2022
lpinca
approved these changes
Jan 15, 2022
aduh95
approved these changes
Jan 15, 2022
This comment has been minimized.
This comment has been minimized.
Flarna
approved these changes
Jan 15, 2022
nodejs-github-bot
commented
Jan 15, 2022
Collaborator
nodejs-github-bot
commented
Jan 16, 2022
Collaborator
nodejs-github-bot
commented
Jan 17, 2022
Collaborator
nodejs-github-bot
commented
Jan 17, 2022
Collaborator
Landed in 20347d5 |
16 tasks
BethGriggs pushed a commit
that referenced
this pull request
Jan 25, 2022
Instead of assigning a boolean, move the function call that assigns a value to the boolean to the only place that boolean is checked. This avoids the function call in cases where it is not needed. Refs: #41488 (review) PR-URL: #41534 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 26, 2022
Instead of assigning a boolean, move the function call that assigns a value to the boolean to the only place that boolean is checked. This avoids the function call in cases where it is not needed. Refs: #41488 (review) PR-URL: #41534 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.
Refs: #41488 (review)