Skip to content

build: fix libuv builds for android aarch64 - #41555

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
RaisinTen:fix-libuv-builds-for-android
Jan 18, 2022
Merged

build: fix libuv builds for android aarch64#41555
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
RaisinTen:fix-libuv-builds-for-android

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Jan 16, 2022

Copy link
Copy Markdown
Member

This syncs up the source list in

node/deps/uv/uv.gyp

Lines 257 to 265 in b2edcfe

'src/unix/linux-core.c',
'src/unix/linux-inotify.c',
'src/unix/linux-syscalls.c',
'src/unix/linux-syscalls.h',
'src/unix/pthread-fixes.c',
'src/unix/android-ifaddrs.c',
'src/unix/procfs-exepath.c',
'src/unix/random-getrandom.c',
'src/unix/random-sysctl-linux.c',

with

node/deps/uv/CMakeLists.txt

Lines 218 to 227 in b2edcfe

src/unix/android-ifaddrs.c
src/unix/linux-core.c
src/unix/linux-inotify.c
src/unix/linux-syscalls.c
src/unix/procfs-exepath.c
src/unix/pthread-fixes.c
src/unix/random-getentropy.c
src/unix/random-getrandom.c
src/unix/random-sysctl-linux.c
src/unix/epoll.c)
.

Fixes: #41380

Signed-off-by: Darshan Sen raisinten@gmail.com

@nodejs-github-bot

nodejs-github-bot commented Jan 16, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Jan 16, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTenRaisinTen mentioned this pull request Jan 16, 2022
Closed
@RaisinTen

RaisinTen commented Jan 16, 2022

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/libuv

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 16, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41935/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 50b7ab9 into nodejs:masterJan 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 18, 2022

Copy link
Copy Markdown
Collaborator

Landed in 50b7ab9

@RaisinTen
RaisinTen deleted the fix-libuv-builds-for-android branch January 19, 2022 01:27
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@RaisinTen@BethGriggs
build: fix libuv builds for android aarch64
7c2b586
This syncs up the source list in
https://github.com/nodejs/node/blob/b2edcfee46097fe8e0510a455b97d5c6d0cac5ec/deps/uv/uv.gyp#L257-L265
with
https://github.com/nodejs/node/blob/b2edcfee46097fe8e0510a455b97d5c6d0cac5ec/deps/uv/CMakeLists.txt#L218-L227.
Fixes: #41380
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #41555
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@RaisinTen@danielleadams
build: fix libuv builds for android aarch64
2c48594
This syncs up the source list in
https://github.com/nodejs/node/blob/b2edcfee46097fe8e0510a455b97d5c6d0cac5ec/deps/uv/uv.gyp#L257-L265
with
https://github.com/nodejs/node/blob/b2edcfee46097fe8e0510a455b97d5c6d0cac5ec/deps/uv/CMakeLists.txt#L218-L227.
Fixes: #41380
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #41555
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@RaisinTen@danielleadams
build: fix libuv builds for android aarch64
1e3c9eb
This syncs up the source list in
https://github.com/nodejs/node/blob/b2edcfee46097fe8e0510a455b97d5c6d0cac5ec/deps/uv/uv.gyp#L257-L265
with
https://github.com/nodejs/node/blob/b2edcfee46097fe8e0510a455b97d5c6d0cac5ec/deps/uv/CMakeLists.txt#L218-L227.
Fixes: #41380
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #41555
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@mmarchinimmarchinimmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.libuvIssues and PRs related to the libuv dependency or the uv binding.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cross compiling failed on node v16.13.1 for android aarch64

10 participants

@RaisinTen@nodejs-github-bot@jasnell@lpinca@cjihrig@tniessen@gengjiawen@mmarchini@richardlau@aduh95