Skip to content

doc: clarify v5.1.1 notable items - #4156

Closed
rvagg wants to merge 1 commit into
nodejs:v5.xfrom
rvagg:v5.1.1-release-notes-update
Closed

doc: clarify v5.1.1 notable items#4156
rvagg wants to merge 1 commit into
nodejs:v5.xfrom
rvagg:v5.1.1-release-notes-update

Conversation

@rvagg

@rvaggrvagg commented Dec 4, 2015

Copy link
Copy Markdown
Member
  • Include reference to CVE-2015-8027
  • Fix "socket may no longer have a socket" reference
  • Expand on non-existent parser causing the error
  • Soften language for CVE-2015-3193 as impact may not be as great as
    expected, also trim to match v4.2.3 language
  • Clarify that CVE-2015-3194 affects TLS servers using client
    certificate authentication
  • Include reference to CVE-2015-6764

* Include reference to CVE-2015-8027
* Fix "socket may no longer have a socket" reference
* Expand on non-existent parser causing the error
* Soften language for CVE-2015-3193 as impact may not be as great as
expected, also trim to match v4.2.3 language
* Clarify that CVE-2015-3194 affects TLS servers using _client
certificate authentication_
* Include reference to CVE-2015-6764
@JungMinuJungMinu added the doc Issues and PRs related to the documentations. label Dec 4, 2015
Comment threadCHANGELOG.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I speculate that attempts trigger -> attempts to trigger
(sorry If I'm wrong)

@JungMinu

Copy link
Copy Markdown
Member

LGTM with one small comment :)

@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@jasnell

Copy link
Copy Markdown
Member

LGTM

rvagg added a commit that referenced this pull request Dec 5, 2015
* Include reference to CVE-2015-8027
* Fix "socket may no longer have a socket" reference
* Expand on non-existent parser causing the error
* Soften language for CVE-2015-3193 as impact may not be as great as
expected, also trim to match v4.2.3 language
* Clarify that CVE-2015-3194 affects TLS servers using _client
certificate authentication_
* Include reference to CVE-2015-6764
PR-URL: #4156
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvaggrvagg closed this Dec 5, 2015
@rvagg
rvagg deleted the v5.1.1-release-notes-update branch December 5, 2015 04:30
@rvagg

rvagg commented Dec 5, 2015

Copy link
Copy Markdown
MemberAuthor

thanks, fixed and landed @ 6c16c40

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rvagg@JungMinu@cjihrig@jasnell