Uh oh!
There was an error while loading. Please reload this page.
crypto: remove wildcard options for checkEmail - #41599
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: nodejs#41571
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Jan 19, 2022
Collaborator
bnb
approved these changes
Jan 19, 2022
bnb
left a comment
Contributor
There was a problem hiding this comment.
+1 if they truly have no effect
17 tasks
tniessen
commented
Jan 20, 2022
MemberAuthor
To elaborate, these four options only affect how OpenSSL's |
tniessen
commented
Jan 20, 2022
MemberAuthor
cc @nodejs/crypto |
19 tasks
17 tasks
panva
approved these changes
Jan 22, 2022
panva pushed a commit
that referenced
this pull request
Jan 22, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
panva
commented
Jan 22, 2022
Member
Landed in 5aa4010 |
tniessen
commented
Jan 22, 2022
MemberAuthor
This was referenced Jan 23, 2022
BethGriggs pushed a commit
that referenced
this pull request
Jan 25, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 28, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 2, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 3, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 14, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard options do not affect
X509_check_email.Refs: openssl/openssl#17536
Refs: #41571