Skip to content

deps: upgrade to V8 4.7.80.25 - #4160

Closed
ofrobots wants to merge 1 commit into
nodejs:masterfrom
ofrobots:v8-4.7.80.25
Closed

deps: upgrade to V8 4.7.80.25#4160
ofrobots wants to merge 1 commit into
nodejs:masterfrom
ofrobots:v8-4.7.80.25

Conversation

@ofrobots

Copy link
Copy Markdown
Contributor

Pick up the latest patch-level from V8 stable. This includes the following fix:

See also: #4128

R=@nodejs/v8
/cc @vkurchatkin

Pick up the latest patch-level from V8 stable. This includes the following fix:
* v8/v8@c408ea7
Make AstRawString deduplication encoding-agnostic.
BUG=v8:4450
LOG=N
R=hablich@chromium.org
TBR=hablich@chromium.org
Review URL: https://codereview.chromium.org/1494293003
See also: nodejs#4128
@bnoordhuis

Copy link
Copy Markdown
Member

LGTM

@ofrobots

Copy link
Copy Markdown
ContributorAuthor

@mscdexmscdex added the v8 engine Issues and PRs related to the V8 dependency. label Dec 5, 2015
@targos

Copy link
Copy Markdown
Member

LGTM

@ofrobots

Copy link
Copy Markdown
ContributorAuthor

First CI had failure on windows which passed on the second CI: https://ci.nodejs.org/job/node-test-pull-request/928/.

ofrobots added a commit that referenced this pull request Dec 5, 2015
Pick up the latest patch-level from V8 stable. This includes the following fix:
* v8/v8@c408ea7
Make AstRawString deduplication encoding-agnostic.
BUG=v8:4450
LOG=N
R=hablich@chromium.org
TBR=hablich@chromium.org
Review URL: https://codereview.chromium.org/1494293003
See also: #4128
PR-URL: #4160
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
@ofrobots

Copy link
Copy Markdown
ContributorAuthor

Landed in e2dec98.

@rvagg

rvagg commented Dec 8, 2015

Copy link
Copy Markdown
Member

Applying the label dont-land-on-v5.x — @nodejs/v8 would you mind labeling your PRs with this if it shouldn't got on v5.x but it's technically not semver-major? That way we can strip them out when looking at the differences and what needs to be merged.

@rvaggrvagg mentioned this pull request Dec 17, 2015
@ofrobotsofrobots mentioned this pull request Dec 23, 2015
vkurchatkin added a commit that referenced this pull request Dec 23, 2015
Original commit message:
Make AstRawString deduplication encoding-agnostic.
R=jkummerow@chromium.org
BUG=v8:4450
LOG=N
Review URL: https://codereview.chromium.org/1411103006
Cr-Commit-Position: refs/heads/master@{#31624}
Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
vkurchatkin added a commit that referenced this pull request Jan 7, 2016
Original commit message:
Make AstRawString deduplication encoding-agnostic.
R=jkummerow@chromium.org
BUG=v8:4450
LOG=N
Review URL: https://codereview.chromium.org/1411103006
Cr-Commit-Position: refs/heads/master@{#31624}
Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Original commit message:
Make AstRawString deduplication encoding-agnostic.
R=jkummerow@chromium.org
BUG=v8:4450
LOG=N
Review URL: https://codereview.chromium.org/1411103006
Cr-Commit-Position: refs/heads/master@{#31624}
Ref: #4160
PR-URL: #4128
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Pick up the latest patch-level from V8 stable. This includes the following fix:
* v8/v8@c408ea7
Make AstRawString deduplication encoding-agnostic.
BUG=v8:4450
LOG=N
R=hablich@chromium.org
TBR=hablich@chromium.org
Review URL: https://codereview.chromium.org/1494293003
See also: nodejs#4128
PR-URL: nodejs#4160
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ofrobots@bnoordhuis@targos@rvagg@mscdex