Uh oh!
There was an error while loading. Please reload this page.
util: remove unused fast path in internal debuglog - #41605
Merged
Conversation
The internal `debuglog()` is never called with 0 parameters. Remove the fast-path for that situation. If it ever occurs, it will fall through to the default path.
nodejs-github-bot
commented
Jan 21, 2022
Collaborator
Trott
commented
Jan 21, 2022
MemberAuthor
@nodejs/util |
addaleax
approved these changes
Jan 22, 2022
targos
approved these changes
Jan 24, 2022
nodejs-github-bot
commented
Jan 24, 2022
Collaborator
Landed in 49ba210 |
nodejs-github-bot
commented
Jan 24, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41605 ✔ Done loading data for nodejs/node/pull/41605 ----------------------------------- PR info ------------------------------------ Title util: remove unused fast path in internal debuglog (#41605) Author Rich Trott (@Trott) Branch Trott:debuglog -> nodejs:master Labels util, author ready, needs-ci Commits 1 - util: remove unused fast path in internal debuglog Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41605 Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41605 Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 19 Jan 2022 22:14:10 GMT ✔ Approvals: 2 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/41605#pullrequestreview-860251448 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41605#pullrequestreview-861035111 ⚠ This PR was merged on Mon, 24 Jan 2022 14:39:22 GMT ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-01-21T19:07:38Z: https://ci.nodejs.org/job/node-test-pull-request/42072/ - Querying data for job/node-test-pull-request/42072/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1740412607 |
targos
commented
Jan 24, 2022
Member
How could the CQ both land and fail the same PR? |
BethGriggs pushed a commit
that referenced
this pull request
Jan 25, 2022
The internal `debuglog()` is never called with 0 parameters. Remove the fast-path for that situation. If it ever occurs, it will fall through to the default path. PR-URL: #41605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 2, 2022
The internal `debuglog()` is never called with 0 parameters. Remove the fast-path for that situation. If it ever occurs, it will fall through to the default path. PR-URL: #41605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 3, 2022
The internal `debuglog()` is never called with 0 parameters. Remove the fast-path for that situation. If it ever occurs, it will fall through to the default path. PR-URL: #41605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 14, 2022
The internal `debuglog()` is never called with 0 parameters. Remove the fast-path for that situation. If it ever occurs, it will fall through to the default path. PR-URL: #41605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal
debuglog()is never called with 0 parameters. Remove thefast-path for that situation. If it ever occurs, it will fall through to
the default path.