test: remove error allowance in debugger test by MrJithil · Pull Request #41640 · nodejs/node

MrJithil · 2022-01-22T06:02:30Z

Completed a TODO Task

benjamingr · 2022-01-22T07:58:19Z

Thanks!

cc @Trott (last blame on the file though I think for moving it?) and @nodejs/inspector (is this safe? I'm missing context, will also start a CI run)

nodejs-github-bot · 2022-01-22T08:07:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42080/

Trott

LGTM if CI is green. There's another one later in the file but no idea if it is similarly necessary or not.

This was moved from https://github.com/nodejs/node-inspect/blob/643179ef5e0452a52ceef2c5e7c8ca42ab00280f/test/cli/exceptions.test.js#L24-L25 which was authored by @jkrems so a review from them would be nice.

Trott · 2022-01-22T14:33:01Z

This may need some dont-backport labels. Not sure.

RaisinTen

This too can be changed

node/test/sequential/test-debugger-exceptions.js

Lines 69 to 70 in 0e6db9c

// TODO: Remove FATAL ERROR once node doesn't show a FATAL ERROR anymore
.then(()=>cli.waitFor(/disconnect|FATALERROR/))

Trott · 2022-01-23T16:59:53Z

Let's also make the commit message more useful. Maybe this?

test: remove error allowance in debugger test
Remove allowance for FATAL ERROR. It is no longer needed.

MrJithil · 2022-01-24T11:26:40Z

All comments resolved.

Remove allowance for FATAL ERROR. It is no longer needed.

lpinca

RSLGTM

hybrist

I wish I had the foresight to add a specific issue reference to that TODO. IIRC it was something about different node versions behaving differently. So if the tests pass and aren't flaky, then . Thanks for cleaning this up!

nodejs-github-bot · 2022-01-24T23:17:46Z

Commit Queue failed

- Loading data for nodejs/node/pull/41640
✔ Done loading data for nodejs/node/pull/41640
----------------------------------- PR info ------------------------------------
Title test: remove error allowance in debugger test (#41640)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch MrJithil:works-on-test-1 -> nodejs:master
Labels test, inspector, needs-ci, dont-land-on-v12.x, dont-land-on-v14.x
Commits 1
- test: remove error allowance in debugger test
Committers 1
- MrJithil PR-URL: https://github.com/nodejs/node/pull/41640
Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Jan Krems ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41640
Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Jan Krems --------------------------------------------------------------------------------
ℹ This PR was created on Sat, 22 Jan 2022 06:02:30 GMT
✔ Approvals: 5
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41640#pullrequestreview-860211046
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41640#pullrequestreview-860211421
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41640#pullrequestreview-860319062
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41640#pullrequestreview-861446096
✔ - Jan Krems (@jkrems): https://github.com/nodejs/node/pull/41640#pullrequestreview-861580196
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-01-22T08:07:44Z: https://ci.nodejs.org/job/node-test-pull-request/42080/
⚠ Commits were pushed after the last Full PR CI run:
⚠ - test: remove error allowance in debugger test
- Querying data for job/node-test-pull-request/42080/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1742665860

nodejs-github-bot · 2022-01-24T23:48:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42127/

nodejs-github-bot · 2022-01-25T01:38:07Z

Landed in 938ab0e

benjamingr · 2022-01-25T01:57:13Z

Congrats on your first pull request landing @MrJithil !

Remove allowance for FATAL ERROR. It is no longer needed. PR-URL: #41640 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 22, 2022

benjamingr added inspector Issues and PRs related to the V8 inspector protocol request-ci Add this label to start a Jenkins CI on a PR. labels Jan 22, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2022

Trott approved these changes Jan 22, 2022
View reviewed changes

Trott requested a review from hybrist January 22, 2022 14:32

tniessen approved these changes Jan 22, 2022
View reviewed changes

RaisinTen approved these changes Jan 23, 2022
View reviewed changes

RaisinTen added dont-land-on-v12.x labels Jan 23, 2022

MrJithil force-pushed the works-on-test-1 branch 2 times, most recently from 46565c3 to 1b47ad8Compare January 24, 2022 11:25

RaisinTen reviewed Jan 24, 2022
View reviewed changes

Comment threadtest/sequential/test-debugger-exceptions.js Outdated

Trott changed the title ~~test: completed the TODO~~test: remove error allowance in debugger test Jan 24, 2022

test: remove error allowance in debugger test
a0df5c5
Remove allowance for FATAL ERROR. It is no longer needed.

MrJithil force-pushed the works-on-test-1 branch from 1b47ad8 to a0df5c5Compare January 24, 2022 16:24

lpinca approved these changes Jan 24, 2022
View reviewed changes

hybrist approved these changes Jan 24, 2022
View reviewed changes

benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 24, 2022

benjamingr added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 24, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2022

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2022

nodejs-github-bot merged commit 938ab0e into nodejs:masterJan 25, 2022

MrJithil deleted the works-on-test-1 branch January 27, 2022 05:36

ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged

danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged

	// TODO: Remove FATAL ERROR once node doesn't show a FATAL ERROR anymore
	.then(()=>cli.waitFor(/disconnect\|FATALERROR/))

Uh oh!

Uh oh!

Conversation

MrJithil commented Jan 22, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjamingr commented Jan 22, 2022

Uh oh!

nodejs-github-bot commented Jan 22, 2022

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Jan 22, 2022

Uh oh!

RaisinTen left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Jan 23, 2022

Uh oh!

MrJithil commented Jan 24, 2022

Uh oh!

Uh oh!

lpinca left a comment

Choose a reason for hiding this comment

Uh oh!

hybrist left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 24, 2022

Uh oh!

nodejs-github-bot commented Jan 24, 2022

Uh oh!

nodejs-github-bot commented Jan 25, 2022

Uh oh!

benjamingr commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MrJithil commented Jan 22, 2022•
edited
Loading