Uh oh!
There was an error while loading. Please reload this page.
tools: fix typo in tools/code_cache/README.md - #41657
Merged
Merged
Conversation
nodejs-github-bot
commented
Jan 23, 2022
Collaborator
Review requested:
|
Contributor
Fast-track has been requested by @tniessen. Please 👍 to approve. |
richardlau
approved these changes
Jan 23, 2022
Trott
approved these changes
Jan 23, 2022
cjihrig
approved these changes
Jan 23, 2022
VoltrexKeyva
approved these changes
Jan 23, 2022
nodejs-github-bot
commented
Jan 23, 2022
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41657 ✔ Done loading data for nodejs/node/pull/41657 ----------------------------------- PR info ------------------------------------ Title tools: fix typo in tools/node_cache/README.md (#41657) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:tools-typo-node-cache-readme -> nodejs:master Labels tools, fast-track Commits 1 - tools: fix typo in tools/node_cache/README.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/41657 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41657 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 23 Jan 2022 00:20:24 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41657#pullrequestreview-860252933 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41657#pullrequestreview-860253029 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41657#pullrequestreview-860253133 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41657#pullrequestreview-860254632 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1734775034 |
targos
commented
Jan 23, 2022
Member
node_cache -> code_cache |
Mesteery
approved these changes
Jan 23, 2022
tniessenforce-pushed
the
tools-typo-node-cache-readme
branch
from
January 23, 2022 09:51
d63d8d9 to
8f2c28aCompareaduh95
approved these changes
Jan 23, 2022
aduh95
commented
Jan 23, 2022
Contributor
Landed in c18ca14 |
BethGriggs pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #41657 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Feb 28, 2022
PR-URL: #41657 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41657 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41657 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41657 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.